[17.0][OU-FIX] sale: Order state + locked#4747
Merged
Merged
Conversation
- Preserve a copy of the column `state` for any future need, as we modify its values. - We should only set as locked orders in "done" state. The locking group doesn't matter.
pedrobaeza
force-pushed
the
17.0-ou_fix-sale
branch
from
0d41a54 to
d5da924
Compare
Contributor
Why? |
Member
Author
|
Because that group is only for auto-locking when confirming the sales order or to show the buttons, but the only important thing now is the current order state. You may have the locking group, but have unlocked a specific sales order, or you may not have now the locking group, but lock in the past some orders. Simply |
MiquelRForgeFlow
approved these changes
Feb 19, 2025
Contributor
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 66e8078. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statefor any future need, as we modify its values.@Tecnativa TT49328