[17.0][FIX] avoid test failures resulting from not yet migrated localizations#4734
Merged
Merged
Conversation
Contributor
|
Could you add this to v18 PR too? :) |
Member
Author
|
will do when we get to account v18, for the time being I'm waiting for reviews for the branch initialization + base migration |
Contributor
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at b008ec3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since OCA/OCB@562aca5, the translations of localizations of the companies created by the v16 demo data are actually loaded in account's register_hook, which fails eventually if a localization hasn't been migrated yet.
I don't think we should deactivate the translation loading altogether, because that's a nice sanity check for localizations when we have them.
I also don't think we should modify the account migration script, as our current problem is an artifact of not having localizations migrated yet, which will go away once that's the case. So handling this in the test script seems the way to go to me.