Skip to content

[17.0][OU-ADD] sms: Nothing to do#4622

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
microcom:17.0_ou_sms
Dec 9, 2024
Merged

[17.0][OU-ADD] sms: Nothing to do#4622
OCA-git-bot merged 1 commit into
OCA:17.0from
microcom:17.0_ou_sms

Conversation

@acpMicrocom

@acpMicrocom acpMicrocom commented Oct 23, 2024

Copy link
Copy Markdown

No description provided.

@legalsylvain

legalsylvain commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

/ocabot migration sms

Depends on :

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2024
Open
rvalyi
rvalyi approved these changes Oct 24, 2024
View reviewed changes

@rvalyi rvalyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change indeed; tests probably fail because of one of the dependencies not migrated yet.

This was referenced Oct 24, 2024
Closed
Merged
@legalsylvain legalsylvain mentioned this pull request Oct 24, 2024
Merged
@hbrunn

hbrunn commented Dec 9, 2024

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 9, 2024
@OCA-git-bot
Merge PR #4622 into 17.0
2822d05 
Signed-off-by hbrunn
@OCA-git-bot

OCA-git-bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn

hbrunn commented Dec 9, 2024

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 70a34b3. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 70a34b3 into OCA:17.0 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes
@hbrunn hbrunn hbrunn approved these changes

Assignees

No one assigned

Labels

approved Blocked by dependency merged 🎉 ready to merge

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@acpMicrocom @legalsylvain @hbrunn @OCA-git-bot @rvalyi