[17.0][OU-ADD] web: Nothing to do#4583
Merged
Merged
Conversation
Author
|
Hi @pedrobaeza I have a doubt on this one as well, since I have no case where qweb is used in view_mode for ir.actions.act_window.view (I also scanned the full OCA repo and did not find any). However, I suppose that in order to be more conservative, we could remove any view of type qweb from ir.actions.act_window.view and probably from view_mode string in ir.actions.act_window. |
Member
|
/ocabot migration web |
pedrobaeza
approved these changes
Oct 11, 2024
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
These kind of views was very weird, and also old, like the project status one in sale_timesheet in v13:
If there's a remaining one, it's OK to have an error, as you must replace it properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.