Skip to content

[17.0][OU-ADD] crm: Migration to 17.0#4554

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
microcom:17.0_ou_crm
Feb 17, 2025
Merged

[17.0][OU-ADD] crm: Migration to 17.0#4554
OCA-git-bot merged 1 commit into
OCA:17.0from
microcom:17.0_ou_crm

Conversation

@acpMicrocom

@acpMicrocom acpMicrocom commented Sep 13, 2024

Copy link
Copy Markdown

No description provided.

@legalsylvain legalsylvain added this to the 17.0 milestone Oct 8, 2024
rvalyi
rvalyi approved these changes Oct 18, 2024
View reviewed changes

@rvalyi rvalyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my understanding (I apologize if I'm wrong) we should complete the migration by including a noupdate

@rvalyi

rvalyi commented Oct 19, 2024

Copy link
Copy Markdown
Member

from my understanding (I apologize if I'm wrong) we should complete the migration by including a noupdate

Sorry, I posted this by mistake, the 2 noupdate records are new:

NEW ir.rule: crm.mail_plan_rule_group_sale_manager_lead (noupdate)
NEW ir.rule: crm.mail_plan_templates_rule_group_sale_manager_lead (noupdate)

So they will be created anyway, right? So in fact I think the PR is OK already, sorry for the noise.

@acpMicrocom acpMicrocom changed the title [17.0][OU-ADD] crm: migration to 17.0 [17.0][OU-ADD] crm: Nothing to do Oct 28, 2024
legalsylvain
legalsylvain requested changes Oct 28, 2024
View reviewed changes

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Some remarks inline.

Comment thread openupgrade_scripts/scripts/crm/17.0.1.8/upgrade_analysis_work.txt
@acpMicrocom acpMicrocom changed the title [17.0][OU-ADD] crm: Nothing to do [17.0][OU-ADD] crm: Migration to 17.0 Oct 28, 2024
@legalsylvain

legalsylvain commented Oct 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

/ocabot migration crm

Depends on :

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 29, 2024
Open
This was referenced Oct 30, 2024
Merged
Merged
@hbrunn

hbrunn commented Feb 17, 2025

Copy link
Copy Markdown
Member

as @legalsylvain's comment has been fixed:

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4554-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 560d3f8. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 560d3f8 into OCA:17.0 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain requested changes
@rvalyi rvalyi rvalyi approved these changes
@hbrunn hbrunn hbrunn approved these changes

Assignees

No one assigned

Labels

Blocked by dependency merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

5 participants

@acpMicrocom @rvalyi @legalsylvain @hbrunn @OCA-git-bot