[16.0][OU-IMP] base: Review existent states and compare with installed states in order to update them properly#4509
Open
etobella wants to merge 1 commit into
Open
[16.0][OU-IMP] base: Review existent states and compare with installed states in order to update them properly#4509etobella wants to merge 1 commit into
etobella wants to merge 1 commit into
Conversation
…es in order to update them properly
pedrobaeza
changed the title
pedrobaeza
reviewed
Jul 11, 2024
|
|
||
|
|
||
| def _review_states_xmlids(cr): | ||
| data_file = open(get_resource_path("base", "data", "res.country.state.csv"), "r") |
Member
There was a problem hiding this comment.
Add docstring to explain the purpose of this.
| ir_model_data imd ON imd.res_id = rc.id | ||
| AND imd.model = 'res.country' | ||
| AND imd.module = 'base' | ||
| WHERE rcs.code = %s AND imd.name = %s |
Member
There was a problem hiding this comment.
Is imd.name the best option?
Contributor
If it should go in all versions, maybe better to create an openupgradelib function, and then call it in a single line, in each version. Don't you think ? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this code could go to all version just us a safety review 😉
@pedrobaeza