Skip to content

[17.0][FIX] define openupgradelib git url in test-requirements.txt#4322

Merged
OCA-git-bot merged 2 commits into
OCA:17.0from
grap:17.0-FIX-openupgradelib-dependency
Feb 28, 2024
Merged

[17.0][FIX] define openupgradelib git url in test-requirements.txt#4322
OCA-git-bot merged 2 commits into
OCA:17.0from
grap:17.0-FIX-openupgradelib-dependency

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor

Ref : #4294

Comment thread openupgrade_scripts/README.rst Outdated
:target: https://github.com/OCA/OpenUpgrade/tree/17.0/openupgrade_scripts
:alt: OCA/OpenUpgrade
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fopenupgrade-lightgray.png?logo=github
:target: https://github.com/OCA/openupgrade/tree/17.0/openupgrade_scripts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change in casing? It was correct before

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do that. Pre-commit did it.
Something should be wrong in readme generation.

I'll take a look.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the folder where you download this is in lower case?

@legalsylvain legalsylvain Feb 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the folder where you download this is in lower case?

renamed into Camelcase, and doesn't change anything.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is the problem:

repo_slug: openupgrade

@pedrobaeza pedrobaeza changed the title [FIX] define openupgradelib git url in test-requirements.txt [17.0][FIX] define openupgradelib git url in test-requirements.txt Feb 28, 2024
@legalsylvain legalsylvain force-pushed the 17.0-FIX-openupgradelib-dependency branch from ff23148 to d68a96b Compare February 28, 2024 09:54
@legalsylvain legalsylvain added this to the 17.0 milestone Feb 28, 2024
@legalsylvain

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-4322-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e94f02 into OCA:17.0 Feb 28, 2024
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at be57432. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants