Support Deleted Modules into apriori.py

[mathben]

I am working to automate migration with OpenUpgrade.

By example with Odoo 17, the information about deleting modules is only accessible into file :
https://github.com/OCA/OpenUpgrade/blob/17.0/docsource/modules160-170.rst

But this information is not into Python file like apriori.py :
https://github.com/OCA/OpenUpgrade/blob/17.0/openupgrade_scripts/apriori.py

Like :

# only used here for upgrade_analysis
deleted_modules = [
    # odoo
    "l10n_ae_pos",
    "l10n_it_edi_pa",
    "l10n_lu_peppol_id",
    "l10n_pl_jpk",
    "website_payment_paypal"
]

This can be useful to ignore missing module. OpenUpgrade work correctly.

What do you think?

[legalsylvain]

In thé concept, i'm not against adding such info.

Could you explain how you will use this information ? (With link to the project if possible)

[pedrobaeza]

In principle, I'm against this, as you have to be aware about missing modules for taking the corresponding actions. If the modules have been merged into another, then you already have the tool in the merged_modules section. If the module is really missing because the feature has been lost, then it should appear, and you finally uninstall it, or find an alternative. Example: this module disappears in 17.0, so we saw it and migrate it inside OCA.

[pedrobaeza]

Note that the migration doesn't stop having missing modules.

[mathben]

Here is the commit in which I use the variable "deleted_modules" :
ERPLibre/ERPLibre@247b468

I am creating a migration procedure by automating the technical decisions at the time fo migration.
This information allows me to validate that the module exists in the update environment. I exclude the module from the error list if it is in this deprecated list.

Example, "google_drive" is deprecated because its API was abandonned on 3rd October 2022.
https://github.com/odoo/odoo/blob/15.0/addons/google_drive/models/google_drive.py#L21

We have no trace about it into file apriori.py
https://github.com/OCA/OpenUpgrade/blob/16.0/openupgrade_scripts/apriori.py

The information is here : https://github.com/ERPLibre/OpenUpgrade/blob/16.0/docsource/modules150-160.rst
I can extract it with a GPT, but it's more easy from apriori.py. Or maybe we can generate apriory.py from docsource to reduce redondance?

 Note that the migration doesn't stop having missing modules.

I propose to add only official OCA deprecated module into this list.

This is the list I found for now, I will do more test in few days. Would you like some pull requests?

Odoo 12.0

# Deleted modules
deleted_modules = [
    # odoo
    "anonymization",
    "l10n_be_intrastat",
    "l10n_be_intrastat_2019",
    "pos_data_drinks",
    "report_intrastat",
    "website_forum_doc",
    # OCA/...
]

Odoo 13.0

# Deleted modules
deleted_modules = [
    # odoo
    "hw_posbox_upgrade",
    "l10n_be_hr_payroll",
    "l10n_be_hr_payroll_account",
    "l10n_be_hr_payroll_fleet",
    "l10n_fr_hr_payroll",
    "l10n_in_hr_payroll",
    "l10n_in_schedule6",
    "website_hr",
    # OCA/...
]

Odoo 14.0

# Deleted modules
deleted_modules = [
    # odoo
    "base_gengo",
    "im_support",
    "l10n_cn_standard",
    "theme_bootswatch",
    "web_diagram",
    "website_gengo",
    # OCA/...
]

Odoo 15.0

# Deleted modules
deleted_modules = [
    # odoo
    "adyen_platforms",
    "l10n_bg",
    "l10n_ch_qriban",
    "odoo_referral",
    "payment_odoo_by_adyen",
    # OCA/...
]

Odoo 16.0

# Deleted modules
deleted_modules = [
    # odoo
    "google_drive",
    "google_spreadsheet",
    "l10n_it_edi_sdicoop",
    "l10n_sa_invoice",
    "payment_alipay",
    "payment_ogone",
    "payment_payulatam",
    "payment_payumoney",
    # OCA/...
]

Odoo 17.0

# Deleted modules
deleted_modules = [
    # odoo
    "l10n_ae_pos",
    "l10n_it_edi_pa",
    "l10n_lu_peppol_id",
    "l10n_pl_jpk",
    "website_payment_paypal",
    # OCA/...
]

Odoo 18.0

# Deleted modules
deleted_modules = [
    # odoo
    "pos_mercury",
    "spreadsheet_dashboard_purchase",
    "spreadsheet_dashboard_purchase_stock",
    "website_twitter",
    # OCA/...
]

[sergiocorato]

This could be useful if used by OpenUpgrade, but if it's only used in other softwares it can be misleading as we cannot be sure it's updated.

Anyway, if your goal is to automate OpenUpgrade work, there is already some working option: https://pypi.org/project/odoo-openupgrade-wizard/ , which works from command-line, and /ads on/ my https://github.com/efatto/openupgrader/ /ads off/, which works from inside Odoo.

There will be a round table at next OCA Days on this matter too.

[legalsylvain]

I have mixed feelings :

This could be useful if used by OpenUpgrade, but if it's only used in other softwares it can be misleading as we cannot be sure it's updated.

Quite agree with that.

In the meantime, deleted_modules can be generated at the beginning of an Openupgrade release, quite easely. Then, this list is like a todo list :

• some modules will move into the renamed / merged list after analysis.
• some odoo modules will land in an OCA repo, so it will be put in renamed list also.
• finally, the remaining list is really the list of modules abandonned. (like web_diagram for exemple)

What I like in adding that list in Openupgrade is that it avoids each openupgrade user to ask himself what to do.
I mean, I wondered what to do with web_diagram (#3232), Then, @etobella wondered what to do with web_diagram (#3615)).

Other people have surely asked themselves the same question.

Extra Idea : we could add an optional script, that uninstall automatically the deleted modules. Something like if os.environ.get("OPENUPGRADE_UNINSTALL_DELETED_MODULES", "") == "yes":

CC : @etobella

Finally, I'm quite in favor of adding this list in Openupgrade, with explanation. For me, it doesn't hurt. Do you think it's acceptable, @pedrobaeza ?

Something like :

# Here is the list of Odoo CE modules that disappeared in the 14.0 version
# If a module is finally recovered in an OCA repo, please remove the entry here
# (or put it in the renamed_modules list, if the moduel has been renamed.
# This list is not used for the time being, but is used by extra tools
# See : https://github.com/OCA/OpenUpgrade/issues/5336

# OR : 

# This list is used in the end-migration.py, this modules will be uninstalled, if
# OPENUPGRADE_UNINSTALL_DELETED_MODULES is set to 'yes'
deleted_modules  = [
    "web_diagram",
]

Note : However, I am against listing the OCA modules. (Only the list of Odoo CE modules.) OCA, is like 10000 modules, and port the modules are done lately, monthes or years after the release. So the list will be allways wrong, regarding OCA modules. (only Odoo CE modules are stable, once the release is done). Also a lot of modules doesn't exist in intermediate version, but exists again, 2 or 4 versions later.

What do you think @mathben ?

[pedrobaeza]

The problem I see is that at the end, this is more charge for OpenUpgrade maintainers, as the rest of OCA is not going to maintain this for sure (not with bad intentions, but due to unacknowledged).