Skip to content

[9.0] disable autoinstall - #575

Merged
pedrobaeza merged 4 commits into
OCA:9.0from
hbrunn:9.0-disable_autoinstall
Dec 27, 2016
Merged

[9.0] disable autoinstall#575
pedrobaeza merged 4 commits into
OCA:9.0from
hbrunn:9.0-disable_autoinstall

Conversation

@hbrunn

@hbrunn hbrunn commented Dec 19, 2016

Copy link
Copy Markdown
Member

This is a cherry pick of #133 and #166, with my own addition of not autoinstalling auth_signup. No upstream PR for obvious reasons

@hbrunn hbrunn added this to the 9.0 milestone Dec 19, 2016

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, website_portal does not seem to depend on portal so changing the dependencies of website_portal_sale seems just right. Now, a more pedantic person than me would suggest not to add a dependency on portal but instead change the existing dependency of website_portal_sale on sale into a dependency on 'portal_sale' but technically, that works out the same.

@pedrobaeza

Copy link
Copy Markdown
Member

Can you please explain why do you need to add such dependency on website_portal_sale?

@StefanRijnhart

Copy link
Copy Markdown
Member

@pedrobaeza it has a dependency on xmlids from the portal_sale module, which is not a problem because portal is autoinstalled up until this change and portal_sale is installed as a glue module automatically. Now that portal is no longer autoinstalled, the dependency has to be made explicit otherwise the website_portal_sale module will break.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Indeed, I remember now that my colleague has made this PR trying to improve the situation: odoo#14777

@hbrunn

hbrunn commented Dec 27, 2016

Copy link
Copy Markdown
Member Author

two approves, 7 days - can one of you do the honors @pedrobaeza @StefanRijnhart ?

@pedrobaeza
pedrobaeza merged commit 56e08e1 into OCA:9.0 Dec 27, 2016
@yajo

yajo commented Dec 28, 2016

Copy link
Copy Markdown
Member

Hi everyone, just letting you know this broke OCB build of OCA/website.

@hbrunn

hbrunn commented Dec 28, 2016

Copy link
Copy Markdown
Member Author

then website should fix its dependencies

@yajo

yajo commented Dec 28, 2016

Copy link
Copy Markdown
Member

Not actually dependencies, other things, but it will be fixed soon and linked here, don't worry.

@pedrobaeza

Copy link
Copy Markdown
Member

Fixed here: OCA/website#306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants