fix(guided-nav): deduplicate shared documents in Strategy 2#175
Open
m-abs wants to merge 1 commit into
Open
Conversation
Multiple readingOrder items can link to the same guided-navigation document URL. Strategy 2 treated each alternate as unique (like sync-narration), causing the shared document to be fetched once per referencing item and all its entries to be stamped with the wrong reading-order position. Fix on all three platforms: collect distinct URLs before fetching, then use the textref-based position lookup (same as Strategy 1) instead of the fixed per-item position stamp. Removes _flattenWithFixedPosition (web) which is now dead code.
Collaborator
Author
|
Note: Restored branch from before history rewrite |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple readingOrder items can link to the same guided-navigation
document URL. Strategy 2 treated each alternate as unique (like
sync-narration), causing the shared document to be fetched once per
referencing item and all its entries to be stamped with the wrong
reading-order position.
Fix on all three platforms: collect distinct URLs before fetching, then
use the textref-based position lookup (same as Strategy 1) instead of
the fixed per-item position stamp. Removes _flattenWithFixedPosition
(web) which is now dead code.