Skip to content

Onboarding schema changes - #4285

Merged
wavehassman merged 9 commits into
feature/onboarding-improvementfrom
onboarding/schema-changes
Jun 26, 2026
Merged

Onboarding schema changes#4285
wavehassman merged 9 commits into
feature/onboarding-improvementfrom
onboarding/schema-changes

Conversation

@getheobald

@getheobald getheobald commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Changes

Necessary schema changes for onboarding improvements.

  • Added booleans fields to indicate target dashboards for FAQs, useful links, and milestones
  • Added a TeamJoinRequest model with TeamJoinRequestStatus enum to represent pending/approved/denied requests by new members to join teams
  • Updated faqTransformer accordingly
  • Changed existing orgId pattern on faqs and fixed resulting breakage in recruitment services, part review services, and tests

Notes

The previous getAllOrganizationFaqs service method returned everything that wasn't a part review FAQ, but it's actual function is to return the recruitment FAQs for the recruiting page. I changed it to do that, but I'll need to rename it through the whole stack so it's clear that it's actually just returning recruiting FAQs not all FAQs. But I left a comment and saved that for when I'm actually working on those files.

Totally forgot to add ticket number to commits, soz hope that's ok

Test Cases

No new behavior, just ran existing tests

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

@getheobald getheobald self-assigned this Jun 18, 2026
@getheobald
getheobald requested review from chpy04 and wavehassman June 18, 2026 22:50
@wavehassman
wavehassman marked this pull request as ready for review June 19, 2026 18:09
@getheobald
getheobald changed the base branch from develop to feature/onboarding-improvement June 19, 2026 18:11

@wavehassman wavehassman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Comment thread src/backend/src/services/recruitment.services.ts
Comment thread src/backend/src/prisma/schema.prisma
Comment thread src/backend/src/services/part-review.services.ts Outdated

@wavehassman wavehassman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf!

@wavehassman
wavehassman merged commit 0f8d70b into feature/onboarding-improvement Jun 26, 2026
4 checks passed
@wavehassman
wavehassman deleted the onboarding/schema-changes branch June 26, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants