Skip to content

Fix: New tab opens with scroll position at top #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malibio merged 1 commit into from
Feb 1, 2026
Merged

Fix: New tab opens with scroll position at top #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/desktop-app/src/lib/design/components/base-node-viewer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,9 @@
range.collapse(true);
selection.removeAllRanges();
selection.addRange(range);
element.focus();
// Use preventScroll to avoid browser auto-scrolling when focusing
// This preserves scroll state during tab switching and cursor restoration
element.focus({ preventScroll: true });
return;
}
currentOffset += nodeLength;
Expand All @@ -862,7 +864,9 @@
range.collapse(true);
selection.removeAllRanges();
selection.addRange(range);
element.focus();
// Use preventScroll to avoid browser auto-scrolling when focusing
// This preserves scroll state during tab switching and cursor restoration
element.focus({ preventScroll: true });
}
} catch {
// Silently handle cursor restoration errors
Expand Down
7 changes: 6 additions & 1 deletion packages/desktop-app/src/lib/design/components/textarea-controller.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,12 @@ export class TextareaController {
}

public focus(): void {
this.element.focus();
// Use preventScroll to avoid browser auto-scrolling when focusing
// This is critical for:
// 1. New tab opening - scroll should start at top, not at first focused node
// 2. Tab switching - scroll position should be restored, not overridden by focus
// 3. Arrow navigation - maintains scroll state during node-to-node navigation
this.element.focus({ preventScroll: true });

if (this.pendingCursorPosition !== null) {
this.setCursorPosition(this.pendingCursorPosition);
Expand Down
12 changes: 9 additions & 3 deletions packages/desktop-app/src/lib/services/cursor-positioning-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,10 @@ export class CursorPositioningService {
}

// Focus if requested
// Use preventScroll to avoid browser auto-scrolling when focusing
// This preserves scroll state during tab switching and new tab opening
if (focus) {
textarea.focus();
textarea.focus({ preventScroll: true });
}

// Set cursor position
Expand Down Expand Up @@ -132,8 +134,10 @@ export class CursorPositioningService {
const clampedPosition = Math.max(0, Math.min(position, maxPosition));

// Focus if requested
// Use preventScroll to avoid browser auto-scrolling when focusing
// This preserves scroll state during tab switching and new tab opening
if (focus) {
textarea.focus();
textarea.focus({ preventScroll: true });
}

// Set cursor position
Expand Down Expand Up @@ -187,8 +191,10 @@ export class CursorPositioningService {
absolutePosition += column;

// Focus if requested
// Use preventScroll to avoid browser auto-scrolling when focusing
// This preserves scroll state during tab switching and new tab opening
if (focus) {
textarea.focus();
textarea.focus({ preventScroll: true });
}

// Set cursor position
Expand Down