Closed
Conversation
|
See @gbsallery #159, To be consistent I force it to lower case to respect the initial format. For me, It works fine. |
Contributor
MichaelB2018
added a commit
to MichaelB2018/Pi-Somfy
that referenced
this pull request
Mar 26, 2026
- mymqtt.py: Support both paho-mqtt 1.x and 2.x by detecting CallbackAPIVersion (addresses PR Nickduino#164 by @digitalgravy) - myconfig.py: Uppercase shutterId when writing rolling codes to prevent duplicate config entries with hex IDs (addresses PR Nickduino#156 by @gbsallery and PR Nickduino#159 by @malys) - README.md: Credit community contributors - Add .github/agents/pi-somfy.agent.md for development workflow
Collaborator
|
Superseded by #170. All changes from this PR have been incorporated into the modernization PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with some others, I'm still getting occasional issues whereby the rolling code for a shutter gets written to a lowercase copy of the ID. Obviously, this only happens when you have more than 10 blinds, causing the IDs (which are in hex) to contain alphabetical characters rather than just numbers.
As a crude fix, without doing a full root-cause analysis (as Python is not really my bag), this PR forces the code to be uppercased before writing. This should fix the issue, if not the confusion (so long as your shutter IDs are in uppercase in the first place).