You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello together,
attached pull request fixes a bug which stops the object detector from working if no bbox parameters are provided in the MLKitView xml template. Sorry for the inconvenience.
@NathanWalker, @triniwiz
it would be great if you could have a look at the second issue where the native view is null. The fix I provided works, but to my understanding the native view should never be null in the first place. I suspect that the issues is routed in a problem in core. I have seen timing related issues in the past when mixing different transition animations.
I am observing the problem when I am on a page with the MLKitView and than navigate away using the following code
***** Fatal JavaScript exception - application has been terminated. *****
NativeScript encountered a fatal error:
Uncaught TypeError: Cannot read properties of null (reading 'bounds')
at
onLayout(file: node_modules/@nativescript/mlkit-core/index.ios.js:422:0)
at layout(file: node_modules/@nativescript/core/ui/core/view/index.ios.js:87:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-helper/view-helper-common.js:102:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-common.js:804:18)
at onLayout(file: node_modules/@nativescript/core/ui/layouts/grid-layout/index.ios.js:165:20)
at layout(file: node_modules/@nativescript/core/ui/core/view/index.ios.js:87:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-helper/view-helper-common.js:102:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-common.js:804:18)
at onLayout(file: node_modules/@nativescript/core/ui/layouts/grid-layout/index.ios.js:165:20)
at layout(file: node_modules/@nativescript/core/ui/core/view/index.ios.js:87:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-helper/view-helper-common.js:102:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-common.js:804:18)
at onLayout(file: node_modules/@nativescript/core/ui/layouts/grid-layout/index.ios.js:165:20)
at layout(file: node_modules/@nativescript/core/ui/core/view/index.ios.js:87:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-helper/view-helper-common.js:102:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-common.js:804:18)
at onLayout(file: node_modules/@nativescript/core/ui/page/index.ios.js:476:12)
at layout(file: node_modules/@nativescript/core/ui/core/view/index.ios.js:87:0)
at layoutChild(file: node_modules/@nativescript/core/ui/core/view/view-helper/view-helper-common.js:102:0)
at layoutView(file:///app/ve<…>
Or is this a valid situation that the native view can be null before the object is released and the fix I did is simply required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello together,
attached pull request fixes a bug which stops the object detector from working if no bbox parameters are provided in the MLKitView xml template. Sorry for the inconvenience.
Best regards,
Christoph