You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This changes the documented host wildcard contract, but architecture/security-policy.md still says host wildcard patterns must start with *. or **. and still documents TLD wildcards as a warning. Please update the Host Wildcards section and validation tables to include first-label intra-label patterns like *-aiplatform.googleapis.com, and to match the current error behavior for TLD/single-label wildcard patterns.
The validator test covers *-aiplatform.googleapis.com, but the OPA runtime tests still only cover *.example.com-style host wildcards. Please add a runtime test asserting *-aiplatform.googleapis.com allows a host like us-central1-aiplatform.googleapis.com and does not cross . boundaries. That would lock the validator/runtime alignment this PR is fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*-aiplatform.googleapis.com**inside a labelRelated Issue
Fixes #1303
Changes
*./**.prefix requirement with label-position validation that matches the OPAglob.match(..., ["."])boundary model.*-aiplatform.googleapis.com,**.example.com,foo.*.example.com,foo**.example.com,*com, bare*/**, and TLD wildcards.Testing
mise run pre-commitcargo fmt --all -- --checkgit diff --checkcargo test -p openshell-sandbox validate_wildcard_host -- --nocapturecargo test -p openshell-sandboxcargo clippy -p openshell-sandbox --all-targets -- -D warningsChecklist