Add workflow for running cpu pytests#13
Merged
Merged
Conversation
Contributor
Author
|
@ryantwolf Looks like Nemo-toolkit install fails in a python 3.9 environment (can reproduce locally). I can skip 3.9 tests here for the time being, but not sure if it's supposed to work with 3.9 or not. |
Contributor
|
@ayushdg After talking with folks, looks like NeMo only supports Python 3.10 and above now. So we should bump our minimum version too. |
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
ayushdg
force-pushed
the
ayushdg/ci/add-pytest-action
branch
from
4c34630 to
2cdc937
Compare
Contributor
Author
Thanks, I'll limit the scope of the PR to 3.10 testing. We can bump the minimum version in a followup. |
ayushdg
added a commit
that referenced
this pull request
Mar 21, 2024
* Add workflow for cpu pytests Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Install wheel to fix fasttext import Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Omit python 3.8, do not fast fail Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Check if updating setuptools/pip changes cython errors Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Explicitly install cython Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Try freeing up space before install Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Try rapids_no_initialize Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * remove python 3.9 testing for now Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
jnke2016
pushed a commit
to jnke2016/Curator
that referenced
this pull request
Nov 12, 2025
* Add workflow for cpu pytests Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Install wheel to fix fasttext import Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Omit python 3.8, do not fast fail Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Check if updating setuptools/pip changes cython errors Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Explicitly install cython Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Try freeing up space before install Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * Try rapids_no_initialize Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> * remove python 3.9 testing for now Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.