CONFIG: .Net 10 and Package Upgrade

[Hassaero110]

Fixes AB#29898

Updated check list:

Checklist

• build.yml is updated (via the infrastructure project - branchName removed)
• prLinter is updated (via the infrastructure project- branchName removed)
• all csproj files target .net10 <TargetFramework>net10.0</TargetFramework>
• all test project uses xunit 3
  • dotnet add package xunit.v3 --version 3.2.2
  • dotnet add package xunit.runner.visualstudio
  • dotnet add package xunit.analyzers
• program.cs is updated to 10.x for the dotnet version
• all the pipeline components on their latest version
• all nuget packages up to date
• ADotNet on 5.1.0

[Copilot]

Pull request overview

Updates project configuration to align remaining components with the repository’s move to .NET 10, and refreshes one test dependency in a backup test project.

Changes:

• Upgrade NHSISL.LibPostalNet from netstandard2.1 to net10.0.
• Upgrade “Backup” test projects to net10.0.
• Bump FluentAssertions in the backup Unit test project.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
NHSISL.LibPostalNet/NHSISL.LibPostalNet.csproj	Switches the LibPostal .NET wrapper package target framework to net10.0.
NHSISL.LibPostalClient.Tests.Unit/NHSISL - Backup.LibPostalClient.Tests.Unit.csproj	Moves backup unit tests to net10.0 and updates FluentAssertions (with follow-up recommended to align other test/tooling packages).
NHSISL.LibPostalClient.Tests.Acceptance/NHSISL - Backup.LibPostalClient.Tests.Acceptance.csproj	Moves backup acceptance tests to net10.0 (follow-up recommended to either align dependencies or remove if unused).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

NHSISL.LibPostalClient.Tests.Unit/NHSISL - Backup.LibPostalClient.Tests.Unit.csproj:4

• These "Backup" test project files are not included in LibPostalClient.slnx, but they are still present in the repo and now partially upgraded to net10.0. Keeping backup project files around can cause confusion and accidental restores/tests (especially since they still reference xunit v2 and older dependency versions). Consider removing these backup *.csproj files from source control, or fully aligning them with the active test projects if they are still intended to be buildable.

		<TargetFramework>net10.0</TargetFramework>

NHSISL.LibPostalClient.Tests.Acceptance/NHSISL - Backup.LibPostalClient.Tests.Acceptance.csproj:4

• These "Backup" test project files are not included in LibPostalClient.slnx, but they remain in the repo and are now targeting net10.0 while still carrying older dependency/test framework versions. Consider removing the backup *.csproj from source control, or fully aligning it with the active Acceptance test project if it is still intended to be buildable.

		<TargetFramework>net10.0</TargetFramework>

NHSISL.LibPostalNet/NHSISL.LibPostalNet.csproj:3

• Targeting net10.0 will not build with the SDK versions currently pinned in CI (GitHub Actions uses .NET SDK 8.0.302 for build/test and 7.0.201 for pack). Unless the CI/tooling is updated (or a global.json is added), restores/builds will fail with NETSDK1045. Also, this project is not included in LibPostalClient.slnx, so the CI commands that run at repo root may not even build/pack this project—if LibPostalNet is meant to ship, include it in the solution/build steps.

		<TargetFramework>net10.0</TargetFramework>

NHSISL.LibPostalNet/NHSISL.LibPostalNet.csproj:3

• Changing the TFM from netstandard2.1 to net10.0 is a breaking change for any consumers not already on .NET 10+. If broad compatibility is still desired for the NuGet package, consider multi-targeting (e.g., netstandard2.1;net10.0). If the intent is to drop older frameworks, consider a major version bump and/or explicit release notes callout.

		<TargetFramework>net10.0</TargetFramework>

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

NHSISL.LibPostalClient.Tests.Acceptance/NHSISL - Backup.LibPostalClient.Tests.Acceptance.csproj:4

• This appears to be a backup project file (name includes "Backup") and it is not referenced by the solution. Keeping backup csproj files in the repo can confuse contributors and CI/project discovery (and it’s easy for them to drift from the real project). Consider deleting it from source control instead of updating it.

<Project Sdk="Microsoft.NET.Sdk">

	<PropertyGroup>
		<TargetFramework>net10.0</TargetFramework>

.github/workflows/prLinter.yml:37

• This if condition is effectively always true because it checks whether the literal string ',,' contains ',{prOwner},' (which will never match for a non-empty PR owner). Keeping it makes the workflow harder to understand without changing behavior.

    - name: Check For Associated Issues Or Tasks
      id: check_for_issues_or_tasks
      if: ${{ !contains(',,', format(',{0},', steps.get_pr_info.outputs.prOwner)) }}
      env:
        PR_BODY: ${{ steps.get_pr_info.outputs.description }}

NHSISL.LibPostalClient.Tests.Unit/NHSISL - Backup.LibPostalClient.Tests.Unit.csproj:4

• This appears to be a backup project file (name includes "Backup") and it is not referenced by the solution. Keeping backup csproj files in the repo can confuse contributors and CI/project discovery (and it’s easy for them to drift from the real project). Consider deleting it from source control instead of updating it.

<Project Sdk="Microsoft.NET.Sdk">

	<PropertyGroup>
		<TargetFramework>net10.0</TargetFramework>