This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Refactor / Be more maintainable#7
Merged
Merged
Conversation
|
鸚鵡好可愛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 放棄 react-jss 採用 styled-component
react-jss 是用
氣氣氣氣氣
CSSProperties方式寫的，寫了一堆都是字串的東西又找不到 syntax-highlight的套件
2. 移除 react-dropzone
更新到 v1.10.1 有個大 bug，會導致拖進來檔案時
isDragReject永遠是false等不了更新，所以直接用 native 的 drag & drop API 去做 Uploader
(未完待續 ... #8)