Skip to content

dask: Field.where#464

Merged
davidhassell merged 3 commits into
NCAS-CMS:lama-to-daskfrom
davidhassell:dask-field-where
Oct 26, 2022
Merged

dask: Field.where#464
davidhassell merged 3 commits into
NCAS-CMS:lama-to-daskfrom
davidhassell:dask-field-where

Conversation

@davidhassell
Copy link
Copy Markdown
Collaborator

@davidhassell davidhassell commented Oct 12, 2022

A bit of a tidy, and a change to Data.where to allow leading size one dimensions. Deleted the _broadcast function as it is not used.

@davidhassell davidhassell added the dask Relating to the use of Dask label Oct 12, 2022
Copy link
Copy Markdown
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks, with sensible updates and test_Field_where now passing locally for me. I've raised a few typos but other than that this is good to merge.

Comment thread cf/data/data.py Outdated
Comment thread cf/field.py Outdated
davidhassell and others added 2 commits October 26, 2022 15:05
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
Co-authored-by: Sadie L. Bartholomew <sadie.bartholomew@ncas.ac.uk>
@davidhassell davidhassell merged commit 8908b9f into NCAS-CMS:lama-to-dask Oct 26, 2022
@davidhassell davidhassell deleted the dask-field-where branch November 15, 2022 09:29
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dask Relating to the use of Dask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants