dask: Field.cumsum#461
Merged
davidhassell merged 2 commits intoOct 28, 2022
Merged
Conversation
sadielbartholomew
approved these changes
Oct 13, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
All good overall, with the test method in question now passing, having been adapted and extended in a sensible way. I have raised one question and one comment, but please merge when ready.
This is because it was always flaky
Shhhhh, that can be our secret now!
sadielbartholomew
approved these changes
Oct 28, 2022
Member
sadielbartholomew
left a comment
sadielbartholomew
left a comment
There was a problem hiding this comment.
Good to go now in my eyes, so please merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changes:
masked_as_zeroparameter deprecated (see dask:Dask cumsum#343 for details)coordinateparameter deprecated. This is because it was always flaky, and I didn't want to make the effort to daskify dodgy code that will be going anyway. It is flaky because it allowed non-CF compliant dimension coordinates to be created automatically. Specifically, the moving of the coordinate coordinate values could result in non strictly monotonic values, because the bounds do not have to follow this restriction.