added 2 trigger lines + added 1 function in TriggerResultsNavigator class by gianipez · Pull Request #52 · Mu2e/Offline

gianipez · 2019-11-12T03:25:23Z

Thi pull request contain:

configuration of a new track trigger line and a place holder for a calorimeter-photon trigger
I added the function "state" in the TriggerNavigator class (suggest by Ray Culberston)
tiny changes in the analyzer module ReadTriggerInfo

updates

…unction

brownd1978 · 2019-11-12T21:36:04Z

@@ -0,0 +1,2 @@
+physics.filters.tprCosmicSeedDeMEventPrescale.nPrescale    : 1
+physics.filters.tprCosmicSeedDeMEventPrescale.triggerFlag  : ["PrescaleRandom"]


Git flags this line as not having a newline. I don't think that art cares, but you might add one just in case.

brownd1978 · 2019-11-12T21:36:18Z

@@ -0,0 +1,2 @@
+physics.filters.cprCosmicSeedDeMEventPrescale.nPrescale    : 1
+physics.filters.cprCosmicSeedDeMEventPrescale.triggerFlag  : ["PrescaleRandom"]


Same 'no newline' comment here.

brownd1978 · 2019-11-12T21:36:27Z

@@ -0,0 +1,2 @@
+physics.filters.tprLowPSeedDeMEventPrescale.nPrescale    : 1
+physics.filters.tprLowPSeedDeMEventPrescale.triggerFlag  : ["PrescaleRandom"]


brownd1978 · 2019-11-12T21:36:46Z

@@ -0,0 +1,2 @@
+physics.filters.tprCosmicSeedDeMEventPrescale.nPrescale    : 1
+physics.filters.tprCosmicSeedDeMEventPrescale.triggerFlag  : ["PrescaleRandom"]


OK, done to all of them

bechenard · 2019-11-13T18:24:23Z

-      bool        accepted = accept(name);
-      printf("// %24s  %2li       %i    //\n", name.c_str(), index, accepted == true ? 1:0);
+      bool        good     = accepted(name);
+      printf("// %24s  %2li       %i    //\n", name.c_str(), index, good == true ? 1:0);


I would strongly suggest to leave out printf and use cout (or Mu2e message streamer)

bechenard · 2019-11-13T18:25:20Z

    for (unsigned int i=0; i< _trigPaths.size(); ++i){
      string&path = _trigPaths.at(i);
-      if (trigNavig.accept(path)) _sumHist._hTrigInfo[15]->Fill((double)i);
+      if (trigNavig.accepted(path)) _sumHist._hTrigInfo[15]->Fill((double)i);


Can we make the _sumHist a TH1I (integer) and avoid the cast here?

In the near future, I wanted to improve this code for using the protonbunch intensity as weight. That's why I left TH1F. If we think it's a problem I can switch to TH1I

bechenard · 2019-11-13T18:33:00Z

Ok, then it makes sense. I think leaving a comment in the code in this case is appropriate. But get rid of printf! Let me know when this is done, then I'll approve the request. Bertrand

…

On 11/13/2019 10:30 AM, Gianantonio Pezzullo wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In Trigger/src/ReadTriggerInfo_module.cc <#52 (comment)>: > @@ -707,7 +707,7 @@ namespace mu2e { for (unsigned int i=0; i< _trigPaths.size(); ++i){ string&path = _trigPaths.at(i); - if (trigNavig.accept(path)) _sumHist._hTrigInfo[15]->Fill((double)i); + if (trigNavig.accepted(path)) _sumHist._hTrigInfo[15]->Fill((double)i); In the near future, I wanted to improve this code for using the protonbunch intensity as weight. That's why I left TH1F. If we think it's a problem I can switch to TH1I — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=ABJ27JE3D7A5D5J2MOLNULLQTRBUJA5CNFSM4JL5WEHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLOM7KY#discussion_r345926334>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ27JACCO2QMU4J65QJRSLQTRBUJANCNFSM4JL5WEHA>.

gianipez · 2019-11-13T18:53:32Z

Done. Thanks, Gianantonio Pezzullo, Ph.D. giani.pezzu@gmail.com ********************************************************************************************************** Address: Department of Physics, Yale University, 56 Hillhouse, New Haven, CT-06511, USA **********************************************************************************************************

…

On Nov 13, 2019, at 1:33 PM, Bertrand Echenard ***@***.***> wrote: Ok, then it makes sense. I think leaving a comment in the code in this case is appropriate. But get rid of printf! Let me know when this is done, then I'll approve the request. Bertrand On 11/13/2019 10:30 AM, Gianantonio Pezzullo wrote: > > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In Trigger/src/ReadTriggerInfo_module.cc > <#52 (comment)>: > > > @@ -707,7 +707,7 @@ namespace mu2e { > > for (unsigned int i=0; i< _trigPaths.size(); ++i){ > string&path = _trigPaths.at(i); > - if (trigNavig.accept(path)) _sumHist._hTrigInfo[15]->Fill((double)i); > + if (trigNavig.accepted(path)) _sumHist._hTrigInfo[15]->Fill((double)i); > > In the near future, I wanted to improve this code for using the > protonbunch intensity as weight. That's why I left TH1F. If we think > it's a problem I can switch to TH1I > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <#52?email_source=notifications&email_token=ABJ27JE3D7A5D5J2MOLNULLQTRBUJA5CNFSM4JL5WEHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLOM7KY#discussion_r345926334>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABJ27JACCO2QMU4J65QJRSLQTRBUJANCNFSM4JL5WEHA>. > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=AGCD3EFRCUUYIKQGNFRZADTQTRB53A5CNFSM4JL5WEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7FSYA#issuecomment-553539936>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGCD3ECAV6YDT6VITD7HW5LQTRB53ANCNFSM4JL5WEHA>.

brownd1978 · 2019-11-13T18:59:29Z

On Wed, Nov 13, 2019 at 10:44 AM Gianantonio Pezzullo < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Trigger/src/ReadTriggerInfo_module.cc <#52 (comment)>: > @@ -707,7 +707,7 @@ namespace mu2e { for (unsigned int i=0; i< _trigPaths.size(); ++i){ string&path = _trigPaths.at(i); - if (trigNavig.accept(path)) _sumHist._hTrigInfo[15]->Fill((double)i); + if (trigNavig.accepted(path)) _sumHist._hTrigInfo[15]->Fill((double)i); In the near future, I wanted to improve this code for using the protonbunch intensity as weight. That's why I left TH1F. If we think it's a problem I can switch to TH1I

PBI is only available in MC data. Do you want to restrict this module to that kind of data?

…

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=ABAH574KLBSNLZCRNCLVW5DQTRBUHA5CNFSM4JL5WEHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLOM7KY#discussion_r345926334>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAH57Z2244C7TR6SJFCYK3QTRBUHANCNFSM4JL5WEHA> .

-- David Nathan Brown Dave_Brown@lbl.gov Office Phone (510) 486-7261 Fax 495-2957 Lawrence Berkeley National Lab MS 50R5008 (50-6026C) Berkeley, CA 94720

bechenard

Good!

rlcee · 2019-11-18T18:17:36Z

Thanks for adding the state accessor. Can you also consider adding
the second accessor I mentioned (see below) Thanks
Ray

The other accessor I'm interested in is
unsigned index(unsigned const i)
this is an integer which says at what module in the path
was the path execution stopped. Even better, and in keeping with the
purpose of your class, you could convert this index into a
module name, that would be nice, as it is not obvious how
to do that..

gianipez · 2019-11-18T18:32:22Z

Hi Ray,

I'm asking Kyle how to do it because right now I actually don't know. In the meanwhile, I pushed the changes that I figured were necessary to adapt the genTriggerFcl script to be compatible with python2 and 3.

kutschke · 2019-11-18T19:48:20Z

Hi Giani, Please stick with this until you have a solution. Rob

…

On Nov 18, 2019, at 12:32 PM, Gianantonio Pezzullo ***@***.***> wrote: Hi Ray, I'm asking Kyle how to do it because right now I actually don't know. In the meanwhile, I pushed the changes that I figured were necessary to adapt the genTriggerFcl script to be compatible with python2 and 3. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

gianipez · 2019-11-18T20:18:19Z

Hi Rob, For me it’s fine. I can integrate what Ray asked once Kyle replies to me. I’m in the process of having a few pull requests in the coming weeks. Cheers, Gianantonio Pezzullo, Ph.D. giani.pezzu@gmail.com ********************************************************************************************************** Address: Department of Physics, Yale University, 56 Hillhouse, New Haven, CT-06511, USA **********************************************************************************************************

…

On Nov 18, 2019, at 2:48 PM, Rob Kutschke ***@***.***> wrote: Hi Giani, Please stick with this until you have a solution. Rob > On Nov 18, 2019, at 12:32 PM, Gianantonio Pezzullo ***@***.***> wrote: > > Hi Ray, > > I'm asking Kyle how to do it because right now I actually don't know. In the meanwhile, I pushed the changes that I figured were necessary to adapt the genTriggerFcl script to be compatible with python2 and 3. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or unsubscribe. > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#52?email_source=notifications&email_token=AGCD3ECS54QVSDYSKSATXDTQULWQLA5CNFSM4JL5WEHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEELV4YI#issuecomment-555179617>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGCD3EBGYF7F7F4SLSRG7VDQULWQLANCNFSM4JL5WEHA>.

rlcee

I agreed with Gianni to let the last enhancement go since it will still take a while.
Evenrything else looks fine.

gianipez and others added 8 commits October 28, 2019 15:47

Merge pull request #16 from gianipez/master

c5b4c74

updates

added calo-photon trigger sequence

304f0dc

added sequences for the Cosmic track triggers

f5338cf

added caloPhoton and t(c)prCosmic trigger

40d25f8

updates

18ef6d9

Merge pull request #17 from gianipez/master

dd0597f

updates

settings for cosmic tack triggers

9502a44

added a new function in TriggerResultsNavigator + changed name of a f…

9b66cb0

…unction

brownd1978 requested a review from bechenard November 12, 2019 21:30

brownd1978 self-assigned this Nov 12, 2019

brownd1978 requested a review from rlcee November 12, 2019 21:30

brownd1978 reviewed Nov 12, 2019

View reviewed changes

added new line to the t(c)prCosmicSeedEventPrescaler configuration files

e16eb5e

bechenard reviewed Nov 13, 2019

View reviewed changes

switched printf to std::cout

9ec918b

bechenard approved these changes Nov 13, 2019

View reviewed changes

upgraded the genTriggerFcl script to be compatible with python 2 nd 3

715ff94

rlcee approved these changes Nov 20, 2019

View reviewed changes

brownd1978 merged commit 2ea513e into Mu2e:master Nov 20, 2019

gianipez deleted the triggerUpdate1 branch November 20, 2019 20:56

		@@ -0,0 +1,2 @@
		physics.filters.tprCosmicSeedDeMEventPrescale.nPrescale : 1
		physics.filters.tprCosmicSeedDeMEventPrescale.triggerFlag : ["PrescaleRandom"] No newline at end of file

		@@ -0,0 +1,2 @@
		physics.filters.cprCosmicSeedDeMEventPrescale.nPrescale : 1
		physics.filters.cprCosmicSeedDeMEventPrescale.triggerFlag : ["PrescaleRandom"] No newline at end of file

		@@ -0,0 +1,2 @@
		physics.filters.tprLowPSeedDeMEventPrescale.nPrescale : 1
		physics.filters.tprLowPSeedDeMEventPrescale.triggerFlag : ["PrescaleRandom"] No newline at end of file

Uh oh!

Conversation

gianipez commented Nov 12, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bechenard commented Nov 13, 2019 via email

Uh oh!

gianipez commented Nov 13, 2019 via email

Uh oh!

brownd1978 commented Nov 13, 2019 via email

Uh oh!

bechenard left a comment

Choose a reason for hiding this comment

Uh oh!

rlcee commented Nov 18, 2019

Uh oh!

gianipez commented Nov 18, 2019

Uh oh!

kutschke commented Nov 18, 2019 via email

Uh oh!

gianipez commented Nov 18, 2019 via email

Uh oh!

rlcee left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants