Sequential Mixing Update#50
Merged
Merged
Conversation
gaponenko
reviewed
Nov 12, 2019
| int totalBkgCount_; | ||
| int minSkip_; | ||
| int maxSkip_; | ||
| int skipFactor_; |
Contributor
There was a problem hiding this comment.
Why is this an integer and not a real number? Perhaps I do not quite get the "philosophical" meaning of this factor. I understand the technical meaning and see that it is multiplied with real numbers in its use.
Contributor
Author
There was a problem hiding this comment.
I was just thinking of it as the number of mean microbunches you want to be able to skip in the background frame. I'm happy to change it to a real number or find a better name :)
Contributor
|
Changing it to a real number would make sense. One may want to skip half of a microbunch.
Andrei
…On Tue, 12 Nov 2019, Andrew Edmonds wrote:
AndrewEdmonds11 commented on this pull request.
> @@ -96,8 +92,7 @@ namespace mu2e {
ProtonBunchIntensity pbi_;
int totalBkgCount_;
- int minSkip_;
- int maxSkip_;
+ int skipFactor_;
I was just thinking of it as the number of mean microbunches you want to be able to skip in the background frame. I'm happy to change it to a real number or find a better name :)
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Mu2e_Offline_pull_50-23discussion-5Fr345379169&d=DwICaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=O47fc5vzDTR2V_gla4Ub0Q&m=fH4HL1x2CgctWXbQmIG3G5P5B4Ng-abWMktXwRhzBa8&s=PvZqeJuCoFGi53XBTmKMJDbFp15d0GX2dYnrlnixdFs&e=
|
Contributor
Author
|
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the sequential mixing code so that it will skip a number of background events between 0 and skipFactormeanEventsPBI, rather than between two user-defined fcl parameters. skipFactor is a new fcl parameter that defaults to 1. These changes mean that the skipping will work (i.e. not throw an exception) for all background frames.
I've also double-checked that a background frame with a single file will skip a different number of background events when it wraps around to the beginning again.