Update to root 6.38#1859
Conversation
|
Hi @brownd1978,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 7a92139: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 7a92139.
N.B. These results were obtained from a build of this Pull Request at 7a92139 after being merged into the base branch at ba2d4e5. For more information, please check the job page here. |
|
The one action item you need to get done before merging is to make sure online is prepared. Also for python@3.12.13. |
|
Why is the python version change tied to this PR?
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
…On Mon, Jun 15, 2026 at 18:43 Ray Culbertson ***@***.***> wrote:
*rlcee* left a comment (Mu2e/Offline#1859)
<#1859 (comment)>
The one action item you need to get done before merging is to make sure
online is prepared. Also for ***@***.***
—
Reply to this email directly, view it on GitHub
<#1859?email_source=notifications&email_token=ABAH57YRFYEAWT7IMXKNT535ACQ33A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRGQYDONRRGAZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4714076102>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAH57YFDPI3XC4B6D3WL6D5ACQ33AVCNFSNUABFKJSXA33TNF2G64TZHMZDAMRYGA2DMOJSHNEXG43VMU5TINRVHE3DINJYHEY2C5QC>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It was an upgrade of opportunity. the pyenv installation uses 3.12, but offline was stuck at 3.10 which makes using them together fragile to impossible. root is the only major package which pins the python version for Offline, so upgrading python requires rebuilding root, so as long as I'm updating root, it is a good time to update python. I'm not sure of the compatibility matrix, if you are going to suggest reverting python and rebuilding new root. 3.10 has official EOL later this year, and we should be looking at 3.14, but my main goal was to try to synergize with pyenv. The overarching recommendation from lab spack is to build our pyenv content with our Offline, if we want to use them together, and this would be a step toward the omni env. The omni env would allow you to use dbtool, runtool, root, metacat, pyutils, tensorflow, jupyter all in one process |
|
Sounds reasonable, thanks for the explanation.
…On Tue, Jun 16, 2026 at 7:15 AM Ray Culbertson ***@***.***> wrote:
*rlcee* left a comment (Mu2e/Offline#1859)
<#1859 (comment)>
Why is the python version change tied to this PR?
It was an upgrade of opportunity. the pyenv installation uses 3.12, but
offline was stuck at 3.10 which makes using them together fragile to
impossible. root is the only major package which pins the python version
for Offline, so upgrading python requires rebuilding root, so as long as
I'm updating root, it is a good time to update python. I'm not sure of the
compatibility matrix, if you are going to suggest reverting python and
rebuilding new root. 3.10 has official EOL later this year, and we should
be looking at 3.14, but my main goal was to try to synergize with pyenv.
The overarching recommendation from lab spack is to build our pyenv content
with our Offline, if we want to use them together, and this would be a step
toward the omni env. The omni env would allow you to use dbtool, runtool,
root, metacat, pyutils, tensorflow, jupyter all in one process
—
Reply to this email directly, view it on GitHub
<#1859?email_source=notifications&email_token=ABAH57Z7AW4IA4PJ4NK76PD5AFJALA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZRHE3TENBWGA32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4719724607>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAH57ZR7AG26DGX6FMYXYT5AFJALAVCNFSNUABFKJSXA33TNF2G64TZHMZDAMRYGA2DMOJSHNEXG43VMU5TINRVHE3DINJYHEY2C5QC>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
David Brown ***@***.***
Office Phone (510) 486-7261
Lawrence Berkeley National Lab
M/S 50R5008 (50-6026C) Berkeley, CA 94720
|
|
📝 The HEAD of |
Small fixes due to migrad interface change. Tested with basic validation (cosmicSimReco, ceSimReco, EventNtuple, ...). Note that EventDisplay requires changes to be compatible with root 6.38.
IMHO this is ready to merge. Nightly validation will tell us if anything subtle has changed (it should be run with no other merges that night). This change is easy to back out, poses little risk, and is necessary for EventDisplay to meet operations requirements.