Skip to content

Update to root 6.38#1859

Open
brownd1978 wants to merge 1 commit into
Mu2e:mainfrom
brownd1978:newroot
Open

Update to root 6.38#1859
brownd1978 wants to merge 1 commit into
Mu2e:mainfrom
brownd1978:newroot

Conversation

@brownd1978

Copy link
Copy Markdown
Collaborator

Small fixes due to migrad interface change. Tested with basic validation (cosmicSimReco, ceSimReco, EventNtuple, ...). Note that EventDisplay requires changes to be compatible with root 6.38.

IMHO this is ready to merge. Nightly validation will tell us if anything subtle has changed (it should be run with no other merges that night). This change is easy to back out, poses little risk, and is necessary for EventDisplay to meet operations requirements.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • CosmicReco
  • /

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 7a92139: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 7a92139.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 7a92139 at ba2d4e5
build (prof) Log file. Build time: 08 min 37 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 0 errors 38 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 7a92139 after being merged into the base branch at ba2d4e5.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@rlcee

rlcee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

The one action item you need to get done before merging is to make sure online is prepared. Also for python@3.12.13.

@brownd1978

brownd1978 commented Jun 16, 2026 via email

Copy link
Copy Markdown
Collaborator Author

@rlcee

rlcee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Why is the python version change tied to this PR?

It was an upgrade of opportunity. the pyenv installation uses 3.12, but offline was stuck at 3.10 which makes using them together fragile to impossible. root is the only major package which pins the python version for Offline, so upgrading python requires rebuilding root, so as long as I'm updating root, it is a good time to update python. I'm not sure of the compatibility matrix, if you are going to suggest reverting python and rebuilding new root. 3.10 has official EOL later this year, and we should be looking at 3.14, but my main goal was to try to synergize with pyenv. The overarching recommendation from lab spack is to build our pyenv content with our Offline, if we want to use them together, and this would be a step toward the omni env. The omni env would allow you to use dbtool, runtool, root, metacat, pyutils, tensorflow, jupyter all in one process

@brownd1978

brownd1978 commented Jun 16, 2026 via email

Copy link
Copy Markdown
Collaborator Author

@FNALbuild

Copy link
Copy Markdown
Collaborator

📝 The HEAD of main has changed to 2b0f51a. Tests are now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants