CRV multiple truth planes#378
Open
RobMina wants to merge 5 commits into
Open
Conversation
Replace the single CrvPlaneY scalar parameter with CrvPlaneYs (vector of y-values) and CrvPlaneNames (vector of branch-name suffixes), allowing truth-plane crossing info to be recorded for multiple CRV sectors in a single ntuple job. - EventNtupleMaker_module.cc: fhicl params scalar→sequence; member vars double→vector; _crvcoincsmcplane→_crvcoincsmcplanes (vector of vectors); branch registration in a loop producing crvcoincsmcplane_<name> per plane - CrvInfoHelper.hh / CrvInfoHelper.cc: FillCrvHitInfoCollections signature updated to accept vector of collections and vector of y-values; crossing logic now iterates over all configured planes - fcl/prolog.fcl: update EventNtupleMaker defaults to array form (CrvPlaneYs/CrvPlaneNames replacing CrvPlaneY) - fcl/prolog_crv_planes.fcl: add crvSectorEntryY_v02 table with per-sector entry y-values for T1/EX/T2 in v02 geometry Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…g/exiting the side sectors.
…process MC truth branches of KPP reco datasets.
AndrewEdmonds11
left a comment
AndrewEdmonds11
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, Rob. I have a few comments below but only one is crticial before I merge.
…ns loaded at runtime from GeometryService.
Contributor
Author
|
Thanks @AndrewEdmonds11 ! New implementation just uses a list of string sector names in the FCL and pulls orientation/position from GeometryService at run time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable multiple configurable CRV truth planes. Default behavior is unchanged. Give options for KPP/run2 geometry studies and add a new parameter file for processing MC truth branches from KPP cosmic datasets.