Updates for Real Data Views(CRV.Trk.Cal)#254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactorings to the event display configuration and visualization logic, with a focus on improved geometry handling and more intuitive color mapping for calorimeter and CRV data. The most important changes are summarized below.
Geometry Handling and Configuration
geometryparameter to various FCL example files (extracted_MDC2020.fcl,extracted_MDC2025.fcl,nominal_MDC2020.fcl,nominal_MDC2025.fcl) to clearly distinguish between geometry types in the event display. [1] [2] [3] [4]fcl/extracted.fclto provide more explicit geometry options and improved documentation, and removed unnecessary includes and parameters.EventDisplayManager API and Geometry Support
EventDisplayManager.hhto add geometry-aware methods and members, including:Visualization and Color Mapping Improvements
DataInterface.cc, changed calorimeter digi visualization to color by maximum amplitude (ADC/energy) using a custom orange color scale, instead of coloring by time. Added detailed event labels and debug output. [1] [2] [3] [4] [5]Minor Improvements and Bugfixes
addCrvRecoPulseinfcl/nominal.fclfor more complete CRV information in the nominal geometry.These changes collectively improve geometry configuration, make the event display more intuitive, and provide more relevant visual cues for users.