Bug fix: Only append eod token once when packing / tokenizing#283
Merged
Bug fix: Only append eod token once when packing / tokenizing#283
Conversation
…lag to tokenize function
…e a speical token
mali-git
reviewed
Dec 14, 2024
flxst
requested changes
Dec 16, 2024
Member
flxst
left a comment
There was a problem hiding this comment.
Great work! :)
Found some minor issues and left some comments.
tests/dataloader/test_end_to_end_indexation_and_tokenization.py
Outdated
Show resolved
Hide resolved
flxst
approved these changes
Dec 16, 2024
mali-git
approved these changes
Jan 13, 2025
le1nux
added a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some HF tokenisers such as
xlm-roberta-largeadd special tokens (e.g., eod token) automatically when encoding text, whereas others, such asgpt2, do not add special tokens.This side-effect in the transformers library has lead to the eod token being appended twice when tokenizing / packing our data. We added a check for this and only append the eod token once now:
modalities/src/modalities/dataloader/create_packed_data.py
Lines 327 to 330 in 1c1ccdc
Additionally, we now enforce now that the eod token is a special token.
Additionally, I added a script that verifies the consistency of the indexation and tokenization of a given JSONL file. We run the indexation and tokenization routines in modalities and compare it to tokenized JSONL file to which we applied the HF tokenizer directly.
Checklist before submitting final PR
python tests/tests.py)CHANGELOG_DEV.md)