Skip to content

Fix single quotes - #2675

Merged
DCtheGeek merged 1 commit into
MicrosoftDocs:stagingfrom
alexandair:patch-21
Jul 16, 2018
Merged

Fix single quotes#2675
DCtheGeek merged 1 commit into
MicrosoftDocs:stagingfrom
alexandair:patch-21

Conversation

@alexandair

Copy link
Copy Markdown
Contributor

Change the single quotes around `n to the double quotes.

Change the single quotes around \`n to the double quotes.
@zjalexander

Copy link
Copy Markdown
Contributor

✅ Validation status: passed

File Status Preview URL Details
reference/6/Microsoft.PowerShell.Utility/ConvertFrom-Json.md ✅Succeeded View (powershell-6)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@DCtheGeek

Copy link
Copy Markdown
Contributor

@alexandair Thanks for the contribution!

Looks like this was fixed for 5.1 in #2509. Since it also exists in 5.0, can you please update that version also to make 5.0/5.1/6 all consistent? Then I will gladly accept this PR.

As a side note, I don't believe the -Join is even required when using Get-Content and ConvertFrom-Json in this example. I know it's in 5.0/5.1/6 for each Example 3. Thoughts?

@DCtheGeek DCtheGeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the same change to 5.0 ref doc for consistency.

DCtheGeek added a commit to DCtheGeek/PowerShell-Docs that referenced this pull request Jul 16, 2018
@DCtheGeek DCtheGeek mentioned this pull request Jul 16, 2018
10 tasks
@DCtheGeek

Copy link
Copy Markdown
Contributor

@alexandair Thanks for the contribution! I went ahead and submitted a PR to also update the 5.0 version of this file. Thanks again!

@DCtheGeek
DCtheGeek merged commit c23a904 into MicrosoftDocs:staging Jul 16, 2018
sdwheeler pushed a commit that referenced this pull request Jul 16, 2018
@alexandair
alexandair deleted the patch-21 branch July 17, 2018 10:03
@alexandair

Copy link
Copy Markdown
Contributor Author

Thanks DCtheGeek for fixing it for 5.0.

Sorry, I've missed your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants