Github Action Fixes#1202
Merged
rdemaria merged 8 commits intoSep 30, 2023
Merged
Conversation
This should fix the current issue with failing checks
Test was being skipped so errored but passed
Contributor
|
Ok for me, thanks! It seems complete, can I merge? |
Contributor
Author
|
Yes, it's complete, all checks pass, so as long as you're happy with the changes, should be all good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
old_thick_bendtotrueAfter all of these fixes, all of the actions will pass, without warnings. Also, the actions will take somewhere around 20 minutes, instead of a day, since the actions do not hang waiting for an Ubuntu-18.04 machine.