Skip to content

fix kicker in interpolation#1168

Merged
rdemaria merged 6 commits into
MethodicalAcceleratorDesign:masterfrom
rdemaria:fix_issue_1146
Mar 15, 2023
Merged

fix kicker in interpolation#1168
rdemaria merged 6 commits into
MethodicalAcceleratorDesign:masterfrom
rdemaria:fix_issue_1146

Conversation

@rdemaria

Copy link
Copy Markdown
Contributor

address #1146

@ldeniau

ldeniau commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

There are a few flaws in this improvement.

  1. [hv]kicker haven't [vh]kick attributes, and your test is using only the kick attribute when dealing with [hv]kickers and the [hv]kick attributes with kickers so it's not failing and it doesn't detect the problem.
  2. [hv]kickers and kickers also have the c[hv]kick attributes which are not considered by the PR. The Correct command sets these attributes for orbit correction.
  3. tkickers are not processed. BTW, tkicker have c[hv]kick attributes that are useless since they are never considered by orbit correction, and there are c[hv]flag attributes probably introduced a long time ago to consider/discard tkickers in orbit correction, but they are never used in the code.

@rdemaria

Copy link
Copy Markdown
Contributor Author

Thanks for the comments! Ok for 2 and 3. For 1 I agree with the reasoning, but it was I implemented. The added test shows the correct behaviour!

@rdemaria

Copy link
Copy Markdown
Contributor Author

btw c[hv]kick are part of the element dictionary, but if I understand well only the values in the nodes are used.

@rdemaria rdemaria closed this Mar 15, 2023
@rdemaria rdemaria reopened this Mar 15, 2023
@rdemaria rdemaria merged commit 4c99acb into MethodicalAcceleratorDesign:master Mar 15, 2023
@rdemaria rdemaria deleted the fix_issue_1146 branch March 15, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants