Introduce LAST option in INSTALL and MOVE and change default behaviour#1113
Merged
rdemaria merged 5 commits intoAug 15, 2022
Merged
Conversation
rdemaria
changed the title
tpersson
approved these changes
Aug 15, 2022
tpersson
left a comment
tpersson
left a comment
Contributor
There was a problem hiding this comment.
It is a useful functionality but why do we change the default behaviour? It might cause problems for some users and anyone who wants to change the default behaviour can do so after this PR. Anyway, I don't feel very strongly about it so go ahead if you think there is a good reason to change the default behaviour.
Contributor
Author
|
The reason for the change is that often it is more intuitive and practical to install markers in the same order of the input file. This is the behaviour of the sequence file. Now it is the other way around. I think the benefit of changing the default behaviour outweighs the backward incompatibility in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #1055
Introduce a new option in install and move command "LAST" that controls how an element is place with respect to other elements at the same location.
It changes the default behaviour! Before, a list of install commands at the s will install the element in the reversed order, and now it will respect the command order.
New default is particularly useful for aperture markers that can be place at the same location in case of sharp edges.