fix: permit message verification#382
Merged
Merged
Conversation
Montoya
added a commit
that referenced
this pull request
Jan 21, 2025
* Move ENS Resolution to separate file * lint fixes * Move send form to separate file * chore: refactor signature types to different components (#380) * chore: refactor signature types to different components * fix: injection order of components * Simplify loading a batch of modules * Use parentContainer pattern across all components * Migrate malformed transactions form And committing a naming crime, but we will allow it * Use event listeners for enabling buttons when connected This introduces a new parameters on `globalContext` called `_connected` with a getter and setter. When set to a new value, the setter dispatches a custom event `globalConnectionChange`. Each module with a button that needs to be enabled when MetaMask is connected thus has an event listener for that event. Now, those buttons are enabled via the listener. This gets us part way to relying on listeners for all state changes. * Move encrypt-decrypt to separate module * Migrate encrypt-decrypt and all PPOMs Also fix a few small errors from previous commits * Fix imports * fix: permit message verification (#382) * chore: Split transactions into separate components (#383) * chore: Split transactions into separate components * chore: add index.js to export all modules * chore: add index.js to export all modules * Move interactions section to module files * Move connections to separate files Unfortunately most of the connection logic is still in index.js and is hard to untangle * Wrap an error message in template string * Migrate type onchange handler to module * Move sendDeepLink href set to module * set deep links in erc20 component code * Fix glaring typo * Programmatic sections * lint fixes * Move more events and utils * Lint fix and remove array * Decentralize clearDisplayElements * No more allConnectedButtons * Change innerHTML to innerText * No more initializeFormElements * Move 1559-related DOM updates to separate files * Move updating DOM for deployed contract to separate files * Move updating network specific buttons to separate file * Simplify connection event logic * Two more custom events * Fix small error * Remove unneeded lint disable line * fix: enable defaults on wallet connect (#384) --------- Co-authored-by: Priya <priya.narayanaswamy@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the permit verification error from address missing