fix(lint): many linter corrections - #696
Merged
Merged
Conversation
- mesh-llm-gpu-bench: mark cuda/hip extern blocks unsafe (Rust 2024 requires `unsafe extern "C"`). These files are feature-gated behind `cuda`/`rocm` so the edition migration tool skipped them in the workspace upgrade, breaking every GPU build target on main. - mesh-llm-system/hardware: collapse 7 nested `if` blocks into let-chains to satisfy clippy::collapsible_if under Rust 1.95.0 (linux-gated paths in DefaultCollector/TegraCollector).
michaelneale
approved these changes
May 26, 2026
michaelneale
left a comment
michaelneale
left a comment
Collaborator
There was a problem hiding this comment.
only merge when all green
michaelneale
added a commit
that referenced
this pull request
May 26, 2026
…ammar-logs * origin/main: fix(lint): many linter corrections (#696)
michaelneale
added a commit
that referenced
this pull request
May 26, 2026
* origin/main: fix(lint): many linter corrections (#696) Upgrade workspace to Rust 2024 edition Fix dispatched Swift release manifest flow Fix metadata-only package verification cache
michaelneale
added a commit
that referenced
this pull request
May 26, 2026
…-publish * origin/main: fix(lint): many linter corrections (#696) Upgrade workspace to Rust 2024 edition Fix dispatched Swift release manifest flow Fix metadata-only package verification cache Fix Blacksmith CI discrepancies
IvGolovach
added a commit
that referenced
this pull request
May 26, 2026
Summary Adds a repeatable KV/tool-loop stability certification harness for direct-model agent/tool-call pressure runs, including plan output, manifest evidence, transcript handling, native-log checkpoint scanning, docs, tests, and a repo-local agent skill. Validation * Validation tier: Tier 4 - verification tooling and testing documentation for KV/tool-loop stability certification; no runtime, protocol, workflow, or CI gate change. * git fetch --no-tags origin main:refs/remotes/origin/main: PASS, origin/main at 12aa611. * git rebase origin/main: PASS, rebased cleanly after #695/#696. * git diff --check origin/main...HEAD: PASS, no output * git diff --check: PASS, no output * git diff --cached --check: PASS, no output * python3 -m unittest scripts.tests.test_qa_kv_tool_loop_stability: PASS, 16 passed * python3 -m unittest discover -s scripts/tests: PASS, 43 passed * python3 -m py_compile scripts/qa-kv-tool-loop-stability.py scripts/tests/test_qa_kv_tool_loop_stability.py: PASS * mkdir -p target/kv-tool-loop-stability && python3 scripts/qa-kv-tool-loop-stability.py --models auto,mesh --attempts 1 --pressure-turns 2 --timeout 30 --min-cached-tokens 128 --suffix-prefill-limit 64 --output-dir target/kv-tool-loop-stability/review-smoke --print-plan > /tmp/kv-tool-loop-plan.json && python3 -m json.tool /tmp/kv-tool-loop-plan.json >/dev/null: PASS * Remote PR checks after rebase: PASS, changes + summary green; non-applicable build/test matrices skipped by path filters. * Review/merge state: APPROVED, MERGEABLE, CLEAN. * Ledger: not applicable - not required for selected validation tier/change family. * Version: not applicable - verification tooling/docs only; no release/version sync required. * Not run: cargo check/tests - not required for selected validation tier; no Rust/runtime code changed. * Not run: live direct-model Skippy certification run - no local loaded direct-model endpoint was available; deterministic unit and plan-smoke coverage proves the harness behavior. Rollback * Revert this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #693