Skip to content

Remove --no-restore from dotnet build step#3

Merged
ambvdijk merged 1 commit intomainfrom
hotfix/restore-on-build
Jul 8, 2025
Merged

Remove --no-restore from dotnet build step#3
ambvdijk merged 1 commit intomainfrom
hotfix/restore-on-build

Conversation

@ambvdijk
Copy link
Copy Markdown
Collaborator

@ambvdijk ambvdijk commented Jul 8, 2025

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.
@ambvdijk ambvdijk merged commit 836c0ca into main Jul 8, 2025
2 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 8, 2025

ambvdijk added a commit that referenced this pull request Jul 9, 2025
* Adds a GitHub Actions workflow to run CodeQL security analysis on C# projects. (#2)

* Create codeql.yml

* Update CodeQL workflow to use .NET 9.0.x

Changed the dotnet-version in the CodeQL GitHub Actions workflow from 8.0.x to 9.0.x to align with the project's SDK requirements.

* Set fetch-depth to 0 in CodeQL workflow

Updated the checkout step in the CodeQL workflow to use 'fetch-depth: 0', ensuring the full git history is available for analysis.

* Add develop branch to CI workflow triggers (#1)

Updated dotnet and sonarqube GitHub Actions workflows to trigger on both main and develop branches for push and pull request events. This ensures CI processes run for changes targeting the develop branch.

* Remove --no-restore from dotnet build step (#3)

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.

* Fix incorrect syntax in dotnet.yml (#4)

* Remove --no-restore from dotnet build step

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.

* Update dotnet.yml

* Add Dependabot configuration for NuGet updates (#5)

Introduces a dependabot.yml file to enable automated weekly updates for NuGet dependencies in the repository.

* Add refactored CommandHandlerBase unit tests

Introduces a modular and SOLID-compliant test suite for CommandHandlerBase, including constructor validation, edge case, and shared test infrastructure. Adds new test classes, helpers, and a detailed README describing the new structure. Also adds Moq as a test dependency.

* Add unit tests for CommandHandlerBase.HandleAsync

Introduces tests covering core functionality of the HandleAsync method in CommandHandlerBase, including event envelope creation, ULID generation, timestamp handling, serialization, storage, and abstract method calls.

* Update CI workflows for improved compatibility

Switch SonarQube workflow from Windows to Ubuntu, update path separators for Unix compatibility, and remove PowerShell-specific commands. Minor formatting improvements were made to the dotnet workflow for consistency.

* Update SonarQube workflow for .NET 9 and code coverage

Adds setup for .NET 9.0, configures SonarQube scanner to use OpenCover reports, and updates test command to collect code coverage in OpenCover format. These changes improve code analysis and ensure compatibility with the latest .NET version.

* Update MathMax.EventSourcing.UnitTests/MathMax.EventSourcing.UnitTests.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Make CreateTestCommand static and update test assertion

Changed CreateTestCommand to a static method in CommandHandlerBaseTestFixture for easier access without instantiation. Updated a test in CommandHandlerBaseConstructorTests to use Assert.IsType with exactMatch: false instead of Assert.IsAssignableFrom.

* Refactor test command creation in unit tests

Replaced usage of _fixture.CreateTestCommand() with CommandHandlerBaseTestFixture.CreateTestCommand() in CommandHandlerBaseEdgeCaseTests and CommandHandlerBaseHandleAsyncTests for consistency and clarity.

* Refactor test helpers into separate files

Split TestHelpers.cs into individual files for each test class: TestCommand, TestEvent, TestCommandHandler, SpyTestCommandHandler, TestCommandHandlerWithNullAggregateId, and TestCommandHandlerWithNullVersion. This improves code organization and maintainability.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ambvdijk added a commit that referenced this pull request Jul 9, 2025
* Adds a GitHub Actions workflow to run CodeQL security analysis on C# projects. (#2)

* Create codeql.yml

* Update CodeQL workflow to use .NET 9.0.x

Changed the dotnet-version in the CodeQL GitHub Actions workflow from 8.0.x to 9.0.x to align with the project's SDK requirements.

* Set fetch-depth to 0 in CodeQL workflow

Updated the checkout step in the CodeQL workflow to use 'fetch-depth: 0', ensuring the full git history is available for analysis.

* Add develop branch to CI workflow triggers (#1)

Updated dotnet and sonarqube GitHub Actions workflows to trigger on both main and develop branches for push and pull request events. This ensures CI processes run for changes targeting the develop branch.

* Remove --no-restore from dotnet build step (#3)

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.

* Fix incorrect syntax in dotnet.yml (#4)

* Remove --no-restore from dotnet build step

The build step in the GitHub Actions workflow now runs 'dotnet build' without the '--no-restore' flag, ensuring dependencies are restored during the build process.

* Update dotnet.yml

* Add Dependabot configuration for NuGet updates (#5)

Introduces a dependabot.yml file to enable automated weekly updates for NuGet dependencies in the repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant