[SS-83] fix MySQL dataflow restarts#35458
Merged
patrickwwbutler merged 8 commits intoMaterializeInc:mainfrom Mar 30, 2026
Merged
[SS-83] fix MySQL dataflow restarts#35458patrickwwbutler merged 8 commits intoMaterializeInc:mainfrom
patrickwwbutler merged 8 commits intoMaterializeInc:mainfrom
Conversation
Contributor
|
Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone. PR title guidelines
Pre-merge checklist
|
patrickwwbutler
force-pushed
the
patrick/mysql-df-restart
branch
from
b0d6561 to
6ae9a99
Compare
patrickwwbutler
changed the title
martykulma
approved these changes
Mar 26, 2026
Contributor
martykulma
left a comment
martykulma
left a comment
There was a problem hiding this comment.
Nice work! Cloning the error streams should be ok as we don't expect much data to flow through them.
Some of the logging added is at info, but it seems it should be at warn - I didn't flag all of them though!
def-
added a commit
to def-/materialize
that referenced
this pull request
Mar 31, 2026
def-
reviewed
Apr 18, 2026
| for err in err_data { | ||
| if let ReplicationError::Definite(def_err) = err { | ||
| tracing::info!( | ||
| "ts: {:?} Definite replication error detected in statistics operator: {def_err}, exiting", ts |
Contributor
There was a problem hiding this comment.
It doesn't actually exit, since there are two loops here and we only break out of the inner one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had an issue with "zombie" dataflows going on forever because, when a definite error is emitted at the max GTID, the stats operator continues to emit probes, meaning the output never reaches the max gtid, surfacing the error and killing the dataflow. This addresses this by adding a new input to the statistics operator that takes in error streams from the snapshot and replication operators, which the stats operator then consumes regularly, and exits upon receiving a definite error.
Motivation
https://linear.app/materializeinc/issue/SS-83/mysql-dataflow-restarts-on-definite-error-causes-data-incorrectness
Verification
Added some new tests and updated an existing test