Merged
Conversation
Member
|
@Malvoz no rush but if you could have a listen etc to this, please. I find that announce movement may not be too useful in its current form, but announce zoom might be a bit more useful as an update to that functionality. I had the notion that it would be cool to calculate an approximate scale ratio for the (centre of the) current map view and announce that, e.g. "One centimetre to 47 metres" etc. I guess we would have to add a visual scale bar control too if we did that, but the zoom levels themselves aren't too relatable to anyone just yet, similar to actual coordinates of any kind (that's computer language, not human language). |
Member
|
See checklist |
prushforth
approved these changes
Mar 3, 2023
Member
|
Merging to keep the process going; feel free to comment when possible. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #664