Improve controls in popups#468
Merged
prushforth merged 2 commits intoMaps4HTML:masterfrom May 19, 2021
Malvoz:improve-popup-controls
Merged
Improve controls in popups#468prushforth merged 2 commits intoMaps4HTML:masterfrom Malvoz:improve-popup-controls
prushforth merged 2 commits intoMaps4HTML:masterfrom
Malvoz:improve-popup-controls
Conversation
Member
Author
Member
|
I notice that the content of the popup is not read by NVDA. But it's starting to work better I think. Thanks for this! |
Member
Author
That is caused by #467... |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following item in #247 (comment):
Also replaces the
<div>container formapml-focus-buttonswith<nav>.Comparison
Before
After