Add role='application' to FeatureGroup <g> element#466
Closed
prushforth wants to merge 1 commit intoMaps4HTML:masterfrom
Closed
Add role='application' to FeatureGroup <g> element#466prushforth wants to merge 1 commit intoMaps4HTML:masterfrom
prushforth wants to merge 1 commit intoMaps4HTML:masterfrom
Conversation
Member
|
It seems that NVDA announces everything on the page after pressing a feature to open a popup. At this point, I'm starting to think we're doing the user a disservice by not just making the entire map |
Member
Author
|
Ok I'll have a look at that when I get a chance. |
Member
|
Maybe we should just go ahead and replace I'll go ahead and do some testing with that approach, see how it behaves. |
Member
Author
|
For some reason I didn't experience NVDA reading the whole page. I only tried it on the restaurant page though. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423