Increase default size of primary tap targets#223
Increase default size of primary tap targets#223prushforth merged 1 commit intoMaps4HTML:masterfrom Malvoz:tap-target-size
Conversation
|
With the increased size of controls the already small map is almost 1/4 covered by controls now. does the small size of the default map have to be as small as a video element? |
|
There was agreement to set the default object size to 300x150, but technically MapML could specify any such default size. It's likely more default controls will be added, should we further increase the default size then to make room for those? I don't think increasing the default size solves the problem. Here's a screenshot of a 300x150 video element in Chrome, it contains 4 controls that are 48x48 px: Although the layout of controls for |
|
#216 could also free up some more space btw. |
|
I agree that the controls should show conditionally, I think full screen button should have that behavior, although after adding reload button I'm not sure if that behavior still works properly or not. This PR can be merged without issue though, I can work on conditional controls after I get the current issue I'm working on resolved. |

Fix #215. Although there may still be work to be done in this area, that issue is specifically about increasing the size of the default controls so I think it makes sense to close that one out, given this PR.
Increasing the size of controls obviously leaves less room for additional controls, but that's a separate issue (#224).
Preview
Current
New
(albeit with added
noreloadtocontrolslist)New: larger map size, no controls excluded