Skip to content

feat: vitest#127

Open
CptSchnitz wants to merge 10 commits intopnpm+turbofrom
vitest
Open

feat: vitest#127
CptSchnitz wants to merge 10 commits intopnpm+turbofrom
vitest

Conversation

@CptSchnitz
Copy link
Copy Markdown
Contributor

No description provided.

@CptSchnitz CptSchnitz changed the title feat feat: vitest Apr 12, 2026
Copy link
Copy Markdown
Contributor

@ronenkapelian ronenkapelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. mixed jest-extended versions:
    auth-bundler: ^3.2.4
    auth-cron: ^7.0.0
    auth-manager: ^7.0.0
    Fix: Align all to ^7.0.0

Consider putting it as a global "catalog" version

  1. [Nitpick] alert :)
    token-kiosk: Uses globalSetup.ts
    Others: Use vitest.globalSetup.ts

  2. vitest configs
    auth-cron, auth-bundler are defined under the project
    "root: __dirname"
    and other packages\ apps without it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the config, it should be as in the default, locally not running by default

Copy link
Copy Markdown
Contributor Author

@CptSchnitz CptSchnitz Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what? this is what gemini had to said about it
"it is not clear and has poor grammar. It contains a run-on sentence (comma splice) and the phrasing at the end is awkward and ambiguous."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(node:1557669) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added to [process]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)

It show memory lack,
try maybe:

  • Add proper cleanup in afterAll hooks
  • Consider setMaxListeners() if needed

@@ -0,0 +1,5 @@
// import 'reflect-metadata';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line commented out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants