Merged
Conversation
1st1
reviewed
Oct 12, 2023
| # provide explicit API to choose such implementation detail. | ||
| # Based on current (libuv 1.46) behavior, setting | ||
| # UV_PROCESS_SETUID or UV_PROCESS_SETGID would reliably make | ||
| # libuv fallback to use fork, so let's just use it for now. |
Member
There was a problem hiding this comment.
Ideally we should make a PR to libuv to make it reliably configurable.
1st1
approved these changes
Oct 12, 2023
Merged
fantix
added a commit
that referenced
this pull request
Oct 13, 2023
Changes ======= * Port uvloop to Python 3.12 (#570) (by @1st1, @fantix in 9f82bd7 for #569) * Upgrade libuv to v1.46.0 (#571) (by @fantix in 2e1978c for #571) Fixes ===== * CI fixes (#520, #553) (by @altendky in 7783f1c, @dulmandakh in 1dd40f1) * Make extract_stack resilient to lacking frames. (#563) (by @jhance in 0687643 for #563)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posix_spawn) (CPython discussion bpo-35537)(CPython code snippet of
subprocess.py:)