fix github workflow badge#523
Closed
EFord36 wants to merge 1 commit intoMagicStack:masterfrom
EFord36:badge-fix
Closed
fix github workflow badge#523EFord36 wants to merge 1 commit intoMagicStack:masterfrom EFord36:badge-fix
EFord36 wants to merge 1 commit intoMagicStack:masterfrom
EFord36:badge-fix
Conversation
Contributor
Author
|
Ah, I see that my PR is basically a duplicate of the earlier #522 - sorry, I didn't notice that when opening it somehow, I thought I had checked open PRs and issues :/ The only difference is that my PR also changes the link targets to link to the specific file, which matches the behaviour of the badge more exactly. I think this is very minor though, and that the author of #522 should get the credit here since they beat me to it! Happy to close, leaving open for now due to the slight difference. |
See the linked GitHub issue from the previous version of the badge: badges/shields#8671 In summary, this type of badge was changed in a breaking fashion such that the badges were just linking to the github issue rather than showing the data. Updating the url resolves this. Also update the link of the badge to specify the workflow file rather than the name, which matches the new behaviour of the badge.
Member
|
No problem! I'll merge both in one squashed commit. Thanks for the PR! |
Member
|
Merged in #522, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the badges show like:
See the linked GitHub issue from the previous version of the badge for the root cause: badges/shields#8671
In summary, this type of badge was changed in a breaking fashion such that the badges were just linking to the github issue rather than showing the data. Updating the url resolves this.
Also update the link of the badge to specify the workflow file rather than the name, which matches the new behaviour of the badge.
Let me know if I need to do the Sphinx build - it looks to me like this is done within ReadTheDocs but let me know if there's anything I need to do here.