Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Matthias/ruby singleton - #296

Closed
matthias-springer wants to merge 7 commits into
master-1.9from
matthias/ruby-singleton
Closed

Matthias/ruby singleton#296
matthias-springer wants to merge 7 commits into
master-1.9from
matthias/ruby-singleton

Conversation

@matthias-springer

Copy link
Copy Markdown
Member

Only works with modified GemStone VM (same branch on MagLev/HPI-GSS). See #291.

@zenspider

Copy link
Copy Markdown
Contributor

Can someone look at this and make a decision?

@AllenOtis

Copy link
Copy Markdown
Contributor

The last time 296 was looked at it was theoretically ok to merge,
if you want it . I have no idea how strongly this fix is needed .

It looks like 296 has changes to the VM that I would have to merge
from the HPI branches. Are there any other VM changes from HPI that
you need ? If you want this included in a Darwin + Linux build for
the libmagparse integration it would delay the Darwin build until sometime
in mid April (after spring break). Otherwise we could do a Darwin server
build soon .

Please build a complete list of everything besides 296 that needs merging
into the VM so I can do them all together.

On Tue, Mar 17, 2015 at 4:30 PM, Ryan Davis notifications@github.com
wrote:

Can someone look at this and make a decision?


Reply to this email directly or view it on GitHub
#296 (comment).

@johnnyt johnnyt closed this Mar 18, 2015
@johnnyt

johnnyt commented Mar 18, 2015

Copy link
Copy Markdown
Member

Based on that - I think we should pass for now - I don't want to hold up the Darwin build

Sent from my iPhone

On Mar 17, 2015, at 5:43 PM, Allen Otis notifications@github.com wrote:

The last time 296 was looked at it was theoretically ok to merge,
if you want it . I have no idea how strongly this fix is needed .

It looks like 296 has changes to the VM that I would have to merge
from the HPI branches. Are there any other VM changes from HPI that
you need ? If you want this included in a Darwin + Linux build for
the libmagparse integration it would delay the Darwin build until sometime
in mid April (after spring break). Otherwise we could do a Darwin server
build soon .

Please build a complete list of everything besides 296 that needs merging
into the VM so I can do them all together.

On Tue, Mar 17, 2015 at 4:30 PM, Ryan Davis notifications@github.com
wrote:

Can someone look at this and make a decision?


Reply to this email directly or view it on GitHub
#296 (comment).


Reply to this email directly or view it on GitHub.

@timfel

timfel commented Mar 18, 2015

Copy link
Copy Markdown
Member

We may want to look at this again eventually. There was an issue with Rails 4 without this...

@johnnyt

johnnyt commented Mar 18, 2015

Copy link
Copy Markdown
Member

I agree - I'd love to get this merged in soon.

@AllenOtis - when could we get a darwin build?

I'll bet @zenspider's work on the parser will need some other VM changes - which we could include with this. We could shoot for another VM build after the hack week this summer.

@johnnyt

johnnyt commented Mar 19, 2015

Copy link
Copy Markdown
Member

Agreed - I didn't mean to close this PR - I deleted the master-1.9 branch which closed pull requests associated with it.

I'd love to chat about this more and get it merged in (after we get a darwin build).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants