DK Master Tree Finishup by ze-dom · Pull Request #766 · MUnique/OpenMU

ze-dom · 2026-05-02T14:20:54Z

To-do

Comment changes with source references
UpdatePlugin

Developments

Added Cold magic effect number (similar to Iced; used in Chain Drive and Strike of Destruction skills)
Added Swell Life magic effect maximum values
Added Swell Life Proficiency magic effect
Added Twisting Slash Mastery, Rageful Blow Mastery, Spear Mastery, Mace Mastery, Swell Life Strengthener, and Swell Life Proficiency skill effects
Replaced Stats.PollutionMoveTargetChance and Stats.StunChance for the more generic and descriptive Stats.MasteryMoveTargetChance and Stats.MasteryStunChance, which can serve several classes

Bugfixes

Map names in logs
Changed Chain Drive magic effect number from Iced to Cold
Fixed Life Swell magic effect boost calcs
Fixed MagicEffect comparison in SkillsInitizalizerBase.CreateEffect() (bug introduced in previous PR)
Fixed double wield damage calcs

ze-dom · 2026-05-02T14:26:56Z

-        var baseSkill = skillEntry.GetBaseSkill();
-
-        if (player.GameContext.PlugInManager.GetStrategy<short, IAreaSkillPlugIn>(baseSkill.Number) is { } strategy)
+        if (player.GameContext.PlugInManager.GetStrategy<short, IAreaSkillPlugIn>(skillEntry.Skill.Number) is { } strategy)
        {
            await strategy.AfterTargetGotAttackedAsync(player, target, skillEntry, targetAreaCenter, hitInfo).ConfigureAwait(false);
+            return;
+        }
+
+        var baseSkill = skillEntry.GetBaseSkill();
+        if (player.GameContext.PlugInManager.GetStrategy<short, IAreaSkillPlugIn>(baseSkill.Number) is { } baseSkillStrategy)
+        {
+            await baseSkillStrategy.AfterTargetGotAttackedAsync(player, target, skillEntry, targetAreaCenter, hitInfo).ConfigureAwait(false);
        }


Added for TwistingSlashMasterySkillPlugIn.cs.
Another option is to change the Key there to the base Twisting Slash skill and keep this as before.

ze-dom · 2026-05-02T14:29:16Z

zTeamS6.3, emu

ze-dom · 2026-05-02T14:30:56Z

+        var magicEffect = new MagicEffect(TimeSpan.FromSeconds(2), stunEffectDefinition, [new MagicEffect.ElementWithTarget(powerUp, Stats.IsStunned)]);
+        await attackable.MagicEffectList.AddEffectAsync(magicEffect).ConfigureAwait(false);
+    }
+


zTeamS6.3, emu

ze-dom · 2026-05-02T14:32:49Z

+    {
+        return item.ItemSlot >= InventoryConstants.HelmSlot && item.ItemSlot <= InventoryConstants.BootsSlot;
+    }
+


zTeamS6.3, emu

ze-dom · 2026-05-02T14:40:11Z

        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.ComboBonus, 0.5f, Stats.TotalEnergy));

        result.AttributeCombinations.Add(this.CreateConditionalRelationship(Stats.AttackSpeedAny, Stats.IsOneHandedSwordEquipped, Stats.WeaponMasteryAttackSpeed));
+        result.AttributeCombinations.Add(this.CreateConditionalRelationship(Stats.DoubleDamageChance, Stats.IsSpearEquipped, Stats.SpearMasteryDoubleDamageChance));


zTeamS6.3, emu

ze-dom · 2026-05-02T14:41:20Z

        magicEffect.StopByDeath = true;
        magicEffect.Duration = this.Context.CreateNew<PowerUpDefinitionValue>();
        magicEffect.Duration.ConstantValue.Value = 60f;
+        magicEffect.Duration.MaximumValue = 180f;


ze-dom · 2026-05-02T14:44:15Z

+        var boostPerPartyMember = this.Context.CreateNew<AttributeRelationship>();
+        boostPerPartyMember.InputAttribute = Stats.NearbyPartyMemberCount.GetPersistent(this.GameConfiguration);
+        boostPerPartyMember.InputOperator = InputOperator.Multiply;
+        boostPerPartyMember.InputOperand = 1f / 100;


zTeamS6.3, emu

ze-dom · 2026-05-02T14:45:32Z

+
+        healthPowerUpDefinition.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
+        healthPowerUpDefinition.Boost.ConstantValue.Value = 0.12f;
+        healthPowerUpDefinition.Boost.MaximumValue = 2f;


ze-dom · 2026-05-02T14:48:32Z

+        // one percent per party member in view
+        var boostPerPartyMember = this.Context.CreateNew<AttributeRelationship>();
+        boostPerPartyMember.InputAttribute = Stats.NearbyPartyMemberCount.GetPersistent(this.GameConfiguration);
+        boostPerPartyMember.InputOperator = InputOperator.Multiply;
+        boostPerPartyMember.InputOperand = 1f / 100;
+
+        var manaPowerUpDefinition = this.Context.CreateNew<PowerUpDefinition>();
+        magicEffect.PowerUpDefinitions.Add(manaPowerUpDefinition);
+        manaPowerUpDefinition.TargetAttribute = Stats.SwellLifeManaIncrease.GetPersistent(this.GameConfiguration);
+        manaPowerUpDefinition.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
+        manaPowerUpDefinition.Boost.RelatedValues.Add(boostPerPartyMember);


zTeamS6.3, emu

ze-dom · 2026-05-02T14:50:34Z

+            skill.SkipElementalModifier = true;
+            skill.MagicEffectDef = this.CreateEffect(ElementalType.Ice, MagicEffectNumber.Cold, Stats.IsIced, 10);
+            return;
+        }


zTeamS6.3, emu

ze-dom · 2026-05-02T14:53:49Z

+        {
+            skill.ElementalModifierTarget = Stats.IceResistance.GetPersistent(this.GameConfiguration);
+            skill.SkipElementalModifier = true;
+            skill.MagicEffectDef = this.CreateEffect(ElementalType.Ice, MagicEffectNumber.Cold, Stats.IsIced, 10);


zTeamS6.3, emu

ze-dom · 2026-05-02T14:55:50Z

+    /// The cold effect caused by chain drive and strike of destruction skills. Like <see cref="Iced"/>, it also slows down movement.
+    /// </summary>
+    Cold = 0x56,
+


ze-dom · 2026-05-02T15:11:44Z

zTeamS6.3, emu

ze-dom · 2026-05-06T12:09:54Z

-        if (multiValues == 0 && this.Elements.All(e => e.AggregateType != AggregateType.Multiplicate))
-        {
-            multiValues = 1;
-        }


This is an impossible situation since in line 66 an enumerable with "1" is concatenated.

ze-dom · 2026-05-06T13:56:37Z

+                {
+                    await this.InvokeViewPlugInAsync<IItemDurabilityChangedPlugIn>(p => p.ItemDurabilityChangedAsync(randomArmorItem, false)).ConfigureAwait(false);
+                }
+            }


zTeamS6.3, emu
The sources seem to be bugged here, because they use the attacker's instead of the defender's durability reduction master skill to attenuate the effect.

ze-dom added 2 commits April 30, 2026 16:44

first commit

cf29196

Merge branch 'master' into DK_master_tree_finishup

7be1f3e

ze-dom commented May 2, 2026

View reviewed changes

Comment thread src/GameLogic/PlayerActions/Skills/TwistingSlashMasterySkillPlugIn.cs

Copy link
Copy Markdown

Contributor Author

ze-dom May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

ze-dom commented May 2, 2026

View reviewed changes

Comment thread src/Persistence/Initialization/Skills/LifeSwellProficiencyEffectInitializer.cs

Copy link
Copy Markdown

Contributor Author

ze-dom May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

Double wield damage fix

d21e5fd

ze-dom commented May 6, 2026

View reviewed changes

Finished rageful blow mastery durability reduction effect

722e876

ze-dom commented May 6, 2026

View reviewed changes

Added update plugins

25da2be

Conversation

ze-dom commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ze-dom commented May 2, 2026 •

edited

Loading