Conversation
lbargaoanu
force-pushed
the
explicit_expand
branch
2 times, most recently
from
c6fbdff to
e1ec3d1
Compare
lbargaoanu
force-pushed
the
explicit_expand
branch
3 times, most recently
from
07a680c to
7b2e7b3
Compare
lbargaoanu
force-pushed
the
explicit_expand
branch
3 times, most recently
from
7de7364 to
0d369a2
Compare
lbargaoanu
force-pushed
the
explicit_expand
branch
2 times, most recently
from
76fd4bc to
8c20769
Compare
lbargaoanu
force-pushed
the
explicit_expand
branch
2 times, most recently
from
19ba0ce to
70f9b29
Compare
lbargaoanu
commented
Oct 1, 2020
src/UnitTests/Constructors.cs
Outdated
| } | ||
| class Destination | ||
| { | ||
| public Destination(int value = 2) => Value = value; |
Contributor
Author
There was a problem hiding this comment.
People want to say that the property Value is mapped because this constructor is used.
lbargaoanu
force-pushed
the
explicit_expand
branch
2 times, most recently
from
dbb1a95 to
e12e236
Compare
…rs when constructor mapping
lbargaoanu
commented
Oct 5, 2020
|
|
||
| public IList<IObjectMapper> Mappers { get; } | ||
|
|
||
| public AdvancedConfiguration Advanced { get; } = new AdvancedConfiguration(); |
Contributor
Author
There was a problem hiding this comment.
Not exactly correct, but it seems reasonable to replace Advanced with Internal(), or use Advanced() instead. Easier to upgrade. If some setting is too important for that, we could move it in the public interface.
lbargaoanu
force-pushed
the
explicit_expand
branch
from
81142c9 to
f51f90d
Compare
Contributor
|
Ping me when you want a review 😆 but I'm gonna unsubscribe for now |
This reverts commit b44c13f.
Evaluate Conditional Expressions for projections with subqueries
jbogard
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3504 (comment)