Conversation
Contributor
|
As we don't deploy the docs except on tags - Suggesting that we merge this and push the built docs to the If that doesn't work (it should), we can maybe tag 2023.1.1.1, which is super fun. |
Contributor
Author
|
Sounds good. It would be better to not have to do a release for docs. |
Adoni5
reviewed
Oct 25, 2023
Contributor
Adoni5
left a comment
Adoni5
left a comment
There was a problem hiding this comment.
Looks good to me! I've checked it all builds and renders correctly in the sphinx docs as well 👍🏼
✅
Co-authored-by: Adoni5 <roryjmunro1@gmail.com>
Adoni5
reviewed
Oct 25, 2023
Adoni5
previously approved these changes
Oct 25, 2023
Contributor
Adoni5
left a comment
Adoni5
left a comment
There was a problem hiding this comment.
If we delete those bulk links at the bottom it LGTM
Co-authored-by: Adoni5 <roryjmunro1@gmail.com>
Contributor
Author
|
LGTM |
agrima2010
pushed a commit
to agrima2010/readfish
that referenced
this pull request
Apr 17, 2026
* Fixing bulk file links in readme and adding in a new promethION bulkfile. --------- Co-authored-by: Adoni5 <roryjmunro1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides a new bulk file for promethION and will fix links in the documentation.