Update DanaKit: enable use on iOS 15 & iOS 16 phones#312
Merged
marionbarker merged 1 commit intofeat/danafrom Aug 20, 2025
Merged
Update DanaKit: enable use on iOS 15 & iOS 16 phones#312marionbarker merged 1 commit intofeat/danafrom
marionbarker merged 1 commit intofeat/danafrom
Conversation
Contributor
Author
SummaryThe previous feat/dana version would successfully build on iOS 15, 16 and 18 phones but for iOS 15 and 16 phones, the option to select Dana as a pump was not shown. For the iOS 18 phone, the option was shown and worked as expected. This PR modifies the minimum iOS deployment to 15.1 and runs successfully on multiple Loop test phones. TestConfiguration for Loop:
Test: Confirm for each phone:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SHA for DanaKit