Conversation
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
* support start, stop, calibrate * use let not var * remove print statetment * add Command enum, and logic for start, stop and calibrate * use closures to call transmitter delegate methods * remove extra whitespace and HealthKit dependency * add opcode for calibrateGlucoseRx * add CRC to SessionStopTxMessage * add seconds since epoch, add CRC to SessionStartTxMessage * build CalibrateGlucoseTxMessage * add stubs for TransmitterDelgate methods * remove actions from example app temporarily * revert change to start restoration, add rawValue to log * restore line return at eof * add calibration button * set glucose units in one place * add else clause * revert previous commit * rename synchronize readTimeMessage * add method to read calibration data * fix glucose units in calibrate function * add documentation comments for disambiguation * move Command enum to new file * add private Action enum * add changes to project * round before cast * serialize action as raw value * just use Int, not UInt8 * remove glucoseUnits user preference * use toInt() * use startTime, stopTime rather than time * add lastCalibration as optional property of Glucose * add default value of nil * add thread-safe CommandQueue * create protocol TransmitterCommandSource * remove HealthKit dependency * remove dev team * add custom string for CalibrationState * add start and stop actions to example app * fix button names * use let not var * remove isEmpty, always access list inside lock * don't use default case; use String(describing:) * don't dispatch TransmitterCommandSource methods * mask glucose value to exclude 4 most-significant bits
ps2
pushed a commit
that referenced
this pull request
May 12, 2020
* Implement suspend threshold guardrails * Update project.pbxproj * Tweak suspend threshold description * Updates from design review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.