Skip to content

Schematool: allow - in database usernames #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmsurpre merged 1 commit into from
May 17, 2023
Merged

Schematool: allow - in database usernames #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...utils/src/main/java/org/linuxforhealth/fhir/database/utils/common/DataDefinitionUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* Handles common syntax for generating DDL
*/
public class DataDefinitionUtil {
private static final String NAME_PATTERN_RGX = "[a-zA-Z_]\\w*$";
private static final String NAME_PATTERN_RGX = "[a-zA-Z_][-\\w]*$";
Copy link
Copy Markdown
Member

@lmsurpre lmsurpre May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today i learned that you can use an unescaped - to match within a character class if its the first (or last) char... i always escape these :-)

Copy link
Copy Markdown
Contributor Author

@jobo-prod jobo-prod Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always just use regex101 for this 😄

private static final Pattern NAME_PATTERN = Pattern.compile(NAME_PATTERN_RGX);

/**
Expand Down