Refactoring smart_open usage as an optional dependency#51
Merged
Conversation
Signed-off-by: Dixon Whitmire <dixonwh@gmail.com>
dixonwhitmire
requested review from
LisaWellman,
cragun47 and
klwhaley
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Dixon Whitmire <dixonwh@gmail.com>
Merged
hammadk373
approved these changes
Oct 3, 2022
Member
Author
|
@klwhaley - Additionally, I have tested the "README" demo commands with and without the "optimized-streaming" dependency. |
klwhaley
reviewed
Oct 3, 2022
| [ | ||
| ("/opt/data/data.csv", "file"), | ||
| ("C:/data/data.csv", "file"), | ||
| ("http://somserver/file.dat", "http") |
Contributor
There was a problem hiding this comment.
nit: did you mean to make this someserver? (missing e)
Member
Author
There was a problem hiding this comment.
I will update. Thanks!
klwhaley
approved these changes
Oct 3, 2022
Signed-off-by: Dixon Whitmire <dixonwh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Csv To FHIR project to treat "smart_open" as an optional dependency with the following changes:
Note that the GitHub Actions test jobs DO NOT load the smart_open dependency at this time.
One caveat with this approach is that we can't use mocks or fixtures within the tests to simulate when smart_open is included or excluded since deferred imports are used. However one could argue that this would require more of an "integration" test to fully ensure that data contracts are read from external systems correctly.
closes #50
Signed-off-by: Dixon Whitmire dixonwh@gmail.com