Skip to content

GENER Tweaks#44

Merged
ptomasula merged 33 commits intodevelopfrom
GENER-AdditionalTesting
Sep 15, 2021
Merged

GENER Tweaks#44
ptomasula merged 33 commits intodevelopfrom
GENER-AdditionalTesting

Conversation

@ptomasula
Copy link
Copy Markdown
Member

Related Issue(s):
respec/HSPsquared #57

Problem(s):

  1. The Gener class did not apply scaling factors specified in the NETWORK block when inputting timeseries into a Gener class instance. Though this is not a feature used in our GLWACSO test case, not including this functionality was an oversight and would need to be added in longer term.
  2. The Gener class raises NotImplementedError exceptions when trying to access an unsupported feature (e.g. loading data from a RCHRES as seen in test10). This unhandled exception causes the main function to stop executing. Suggested that we add logic upstream to handle exceptions and warning users of issue rather than stopping model execution.

Solution(s):

  1. Added logic to apply MFACTOR (when specified) to values read from a Copy or Gener class instances within the Gener.init method. See commit 399e861
  2. Added Try Except block to handle NotImplementedError exceptions within main.py's main function. The except block now prints a warning to console that a Gener instance is trying to use unsupported features and may cause model execution errors. See commit 60e76ea

tredder75 and others added 30 commits August 5, 2021 09:12
Fetch upstream commits into `wq-updates-tmr` to squash merge conflicts
@ptomasula ptomasula added the enhancement New feature or request label Sep 15, 2021
@ptomasula ptomasula self-assigned this Sep 15, 2021
@ptomasula ptomasula merged commit e23bdab into develop Sep 15, 2021
@ptomasula ptomasula deleted the GENER-AdditionalTesting branch September 15, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants